fix(install): Warn when another flagsmith on PATH may shadow the install - #97
Conversation
|
Warning Review limit reached
Next review available in: 53 minutes Limit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?Wait for the limit to reset, then comment An organization admin can change what happens after included review limits in Billing. How do review limits work?CodeRabbit enforces per-developer PR review limits within each organization. For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe shell and PowerShell installers now distinguish between new and existing installations. They report the installed version and executable location. They detect other Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: 🟡 Moderate · up to The installer’s new shadowing warnings can be incorrect on Windows and incomplete on Unix-like systems, either flagging non-executable commands or missing a conflicting binary in the current directory. These bounded correctness issues should be fixed before merge. ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: c752a04c-79cb-43c8-bd1f-4a0e95280bbe
📒 Files selected for processing (2)
install.ps1install.sh
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.
matthewelwell
left a comment
There was a problem hiding this comment.
Vibe-approving based on CodeRabbit's approval, and the low blast radius.
Closes #75.
In this PR, we add the following installer script improvements:
flagsmithcommand, walks thePATHto identify each conflicting binary, and lists them with a warning.${INSTALL_DIR}/flagsmithproduces no warning, and the final message now distinguishes the two cases:installed <version> to <path>on first install,updated <version> at <path>when overwriting.Fresh install with an old CLI still on
PATH:Re-running the installer over an existing v2 binary (the smooth update path — no warning):