ci: Bump actions/setup-dotnet from 4 to 5#176
Conversation
Bumps [actions/setup-dotnet](https://github.com/actions/setup-dotnet) from 4 to 5. - [Release notes](https://github.com/actions/setup-dotnet/releases) - [Commits](actions/setup-dotnet@v4...v5) --- updated-dependencies: - dependency-name: actions/setup-dotnet dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
LabelsThe following labels could not be found: Please fix the above issues or remove invalid values from |
![llamapreview[bot]](https://avatars.githubusercontent.com/in/1023541?s=60&v=4){kind=small}
There was a problem hiding this comment.
AI Code Review by LlamaPReview
🎯 TL;DR & Recommendation
Recommendation: Approve with suggestions
This PR updates actions/setup-dotnet from v4 to v5 across CI workflows. No breaking changes observed in the current pipeline, but the major version bump includes runtime and behavior changes that warrant awareness.
🌟 Strengths
- All three workflow files (
ci.yml,codeql.yml,release.yml) updated consistently. - CI build-and-test passed, confirming compatibility with current configuration.
💡 Suggestions (P2)
.github/workflows/ci.yml: Review the full changelog for breaking changes (Node.js 24 requirement, removed .NET version support, cache behavior changes) and verify alignment with project expectations, especiallyglobal.jsonroll‑forward and caching.
💡 Have feedback? We'd love to hear it in our GitHub Discussions.
✨ This review was generated by LlamaPReview Advanced, which is free for all open-source projects. Learn more.
| - name: Setup .NET 8 | ||
| uses: actions/setup-dotnet@v4 | ||
| uses: actions/setup-dotnet@v5 | ||
| with: | ||
| dotnet-version: 8.0.x |
There was a problem hiding this comment.
P2 | Confidence: Medium
The PR updates actions/setup-dotnet from v4 to v5 across all three workflow files (ci.yml, codeql.yml, release.yml). While the CI pipeline (build‑and‑test) succeeded and the related context confirms that no residual @v4 references remain, this is a major version bump with documented breaking changes:
- Upgraded to Node.js 24 (requires runner version ≥2.327.1).
- Removed support for older .NET versions (e.g., .NET 6 and below).
- Changed cache behavior (bumped
@actions/cacheto 5.1.0 with new logging). - Updated install scripts and removed
azureedge.netfallback logic.
The workflow sets dotnet-version: 8.0.x, which is still supported, and windows-latest runners are typically on a recent enough version. Nonetheless, the breaking changes could introduce subtle regressions (e.g., global.json roll‑forward validation now stricter, cache write denial logs).
Suggested action: Review the full changelog (linked in the PR description) and verify that the behavior aligns with the project’s expectations—especially any interaction with global.json or NuGet caching. Since the CI passed, the update is likely safe, but a manual check adds confidence for future builds.
1 participant
Bumps actions/setup-dotnet from 4 to 5.
Release notes
Sourced from actions/setup-dotnet's releases.
... (truncated)
Commits
26b0ec1Expand the CSC problem matcher to light up more errors on GitHub. (#717)da5e548docs(action): explicitly mark all optional inputs with required: false (#737)9bd3b44Improve readability of global.json creation command (#694)4406a63Bump@actions/cacheto 5.1.0, log cache write denied (#746)dc3262dpin actions to commit SHAs in workflows (#744)95a3f8bValidate global.json SDK version before rollForward optimization (#742)9a946fdAdd rollForward note in README, improve proxy health check in e2e tests and b...98af08bSupport global.json's rollForward latest* variants (#538)8404272Update install scripts to v2026.05.19 (#736)f1970f5Don't download releases-index.json to resolve major version (#560)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)