Fix NPC not showing for players without skin when using @mirror - #309
Open
Bruhdows wants to merge 1 commit into
Open
Fix NPC not showing for players without skin when using @mirror#309Bruhdows wants to merge 1 commit into
Bruhdows wants to merge 1 commit into
Conversation
When an NPC uses the @mirror skin setting and is viewed by an offline/cracked player without a skin, the NPC wouldn't render. This fixes it by falling back to the NPC's own skin data if the viewer doesn't have one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📋 Description
When an NPC uses the @mirror skin setting and is viewed by an offline/cracked player without a skin, the NPC wouldn't render. This fixes it by falling back to the NPC's own skin data if the viewer doesn't have one.
✅ Checklist
mainbranch🔍 Changes
🧪 How to Test
@mirrorskin setting