Regenerate stale tie scores and populate the Boundary Checks section - #2
Open
gronke wants to merge 2 commits into
Open
Regenerate stale tie scores and populate the Boundary Checks section#2gronke wants to merge 2 commits into
gronke wants to merge 2 commits into
Conversation
The score files were generated before the calculator's 2024-11-01 rounding fix (RedHatProductSecurity/cvss-v4-calculator#67): scores whose pre-rounded value sits at an x.x5 tie rounded down instead of up. 159 reference entries and 1412 base-threat entries move up one tenth; severities are unaffected. The 33 comment and blank lines in reference-scores previously read "Invalid vector string" and now mirror their vector-file counterparts. regenerate_scores.mjs reproduces the files against the pinned fixed calculator; fetching that one file at its pinned revision is the script's only network access.
The 522 base vectors whose pre-rounded score sits at an x.x5 tie, with expected scores from the fixed calculator. Any implementation without the 2024-11-01 rounding fix scores every one of these a tenth low, so the section now catches the class it was named for.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regenerates the score files against the reference calculator at RedHatProductSecurity/cvss-v4-calculator@d1eafe06 (the merge commit of the 2024-11-01 rounding fix, PR #67), and populates the empty Boundary Checks section.
Invalid vector stringnow mirror their vector-file counterparts, so the two files stay line-aligned without artifacts.vectorFiles/regenerate_scores.mjsreproduces the score files against the sha256-pinned calculator revision; fetching cvss40.js at that revision is its only network access. On top of the calculator it enforces the eleven mandatory base metrics itself (the pinned revision accepts truncated vectors; reported upstream) and preserves existing error entries verbatim when it agrees a line is invalid.