Add numbered Calibration dashboard pagination#41
Conversation
|
@codex review |
|
@copilot review |
|
@coderabbitai review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 562b737e05
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
562b737 to
be38974
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: be38974e6d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@copilot review |
|
@coderabbitai review |
be38974 to
e0f74ea
Compare
|
@copilot review |
|
@coderabbitai review |
|
@codex review |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Summary
Previous, numbered pages, andNextpaginator.pagination.nextOffset, including when the Worker clamps page size below a UI selection.Committedso the public demo first page shows completed files by default.Scope
Calibration Worker admin dashboard UI, docs, and HTML regression coverage only. No registry contract, seeder, or Token Host wrapper behavior changes.
Validation
Latest local validation on
e0f74ea:node --check src/worker/calibration-demo.mjsnode --test test/calibration-worker.test.mjs(15 tests)pnpm test:node(120 tests)pnpm lintpnpm ops:validate(ok: true, tracked secret findings 0)pnpm ops:smoke -- --iterations 3(ok: true)pnpm worker:dry-run(Wrangler 4.107.0, total upload 845.22 KiB / gzip 169.48 KiB)pnpm test(120 Node tests + 29 Forge tests)git diff --checkGitHub CI:
testpassed on latest heade0f74eain run28816555108.Deployment / Live Verification
Deployed to
https://foc-platform-calibration-demo.snissn.workers.devwith Worker versiond92abd1c-cb72-475d-b2c2-708e3a066613.Live checks confirmed:
/admincontains the defaultCommittedfilter, numbered page buttons, serverpagination.nextOffsethandling, and in-flight pager guard code./api/admin/files?live=true&status=Committed&limit=10returns 10 committed rows, object IDs97through88, withhasNextPage=true./api/admin/files?live=true&limit=10returns 97 rows across 10 pages: 57Committed, 40Expiredhistorical rows.Performance
No benchmark required. This is a small static dashboard UI change; Worker dry-run and live deploy succeeded.
AI Review / Merge Status
Internal deep review completed. Codex findings were fixed and resolved: server-returned offset jumps and stale in-flight pagination. Latest-head Codex review on
e0f74eareported no major issues. Latest-head@copilot reviewand@coderabbitai reviewwere requested; Copilot acknowledged with eyes, and no submitted CodeRabbit findings were observed. Merge state isCLEAN; readiness-only handoff, not merged by agent.