Forward coefficient functions to solveAsync, add varying-coefficient regression tests - #91
Merged
nikoscham merged 2 commits intoAug 19, 2026
Conversation
`solve()` passes `this.coefficientFunctions` to `assembleHeatConductionMat`, but `solveAsync()` called the same assembler with only the mesh and the boundary conditions. Any model configured with spatially varying coefficients silently fell back to a uniform conductivity of 1 and a heat source of 0 when solved through the asynchronous path. Pass the coefficients at that call site as well, so both paths assemble the same system. Refs FEAScript#82
The existing regression tests pass no `coefficientFunctions`, so the coefficients resolve to a uniform conductivity of 1 and a heat source of 0. Both are then invisible to the result: multiplying by 1 and adding 0 leaves the assembled system identical to one that never read them. Nothing in the suite could distinguish correct coefficient handling from none at all. These two tests assert closed-form solutions rather than stored reference values, which for a new feature would only record whatever the code produced when the test was written. Each case is chosen so the finite element solution is exact at the nodes, giving a tolerance of 1e-10 instead of 1e-4 and expected values that never need re-deriving when the mesh or element order changes. 1D covers a uniform source against T = x(1 - x)/2, whose exact solution lies outside the finite element space and so pins the quadrature of the source term; the manufactured solution T = x under k = 1 + x and Q = -1 for both element orders, which pins the Gauss point as the evaluation point; the frontal assembler against the matrix assembler; and the coefficient forwarding in `solveAsync`. 2D covers T = x and its rotation T = y, since the 2D assembler is a separate implementation and the 1D path calls the coefficients with x alone. Confirmed to have teeth by mutation: swapping x and y in the 2D assembler moves both 2D cases from 1e-15 to 1e-1, and dropping the coefficients from the `solveAsync` call site fails the 1D suite. Refs FEAScript#82
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows up on #82, on the branch you suggested.
solveAsynccoefficient forwarding —solve()passesthis.coefficientFunctionstoassembleHeatConductionMat;solveAsync()did not, so any model with spatially varying coefficients silently fell back tok = 1,Q = 0on the async path. One-line fix, matching the call site insolve().Regression tests — closed-form solutions rather than stored reference values, with each case chosen so the finite element solution is exact at the nodes, allowing a tolerance of
1e-10. 1D covers a uniform source againstT = x(1-x)/2, the manufactured solutionT = xunderk = 1+x, Q = -1for both element orders, the frontal assembler against the matrix assembler, and thesolveAsyncforwarding above. 2D coversT = xand its rotationT = y.Mutations tested against the new tests. Each was applied to
src/, the suite run, then reverted. Every one is caught, and every one passes the existingHeatConduction1DWalltest, which supplies nocoefficientFunctions:k, always use 1kat a fixed x, not the Gauss pointsolveAsync: no forwardingTwo notes, both pre-existing on
mainand out of scope here:npm testrunsnode --test tests, which fails on Node 22+ (the path is treated as a file).node --testworks — 7 files, 7 pass.main(12c053e,50e8345,c88ed35). No source conflicts; only the committeddist/bundles collide.