fix(site): type Monaco onChange value param (clears ts7006)#208
Merged
Conversation
`onChange={value => ...}` left `value` implicitly `any` — the only error
`astro check` reported on the site. Annotate it `string | undefined` (the
@monaco-editor/react OnChange signature). No behaviour change; `astro check`
is now clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
onChange={value => setEditorValue(value ?? '')}leftvalueimplicitlyany— the only errorastro checkreported on the site (EditorCode.tsx:352ts(7006)). Annotatedvalue: string | undefined(the@monaco-editor/reactOnChangesignature). No behaviour change;astro checknow reports 0 errors.Note: while here I thoroughly investigated the reported "modified-status" bug via Playwright (load / type / delete / undo / run / edit-after-run) — the status is correct in every scenario and the trailing-newline hypothesis doesn't hold (all example sources end with a single consistent
\n). No reproducible bug, so no speculative dirty-tracking refactor.