Skip to content

debug(aws_s3 source): log AWS SDK error metadata for SQS delete failures #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sundaresanr merged 1 commit into from
Jul 9, 2026
Merged

debug(aws_s3 source): log AWS SDK error metadata for SQS delete failures #41

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/internal_events/aws_sqs.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ mod s3 {
BatchResultErrorEntry, DeleteMessageBatchRequestEntry, DeleteMessageBatchResultEntry,
SendMessageBatchRequestEntry, SendMessageBatchResultEntry,
};
use aws_smithy_types::error::metadata::ProvideErrorMetadata;
use metrics::histogram;

use super::*;
Expand Down Expand Up @@ -137,7 +138,7 @@ mod s3 {
pub error: E,
}

impl<E: std::fmt::Display> InternalEvent for SqsMessageDeleteBatchError<E> {
impl<E: std::fmt::Display + ProvideErrorMetadata> InternalEvent for SqsMessageDeleteBatchError<E> {
fn emit(self) {
error!(
message = "Deletion of SQS message(s) failed.",
Expand All @@ -146,6 +147,12 @@ mod s3 {
.collect::<Vec<_>>()
.join(", "),
error = %self.error,
// `Display` for aws SdkError is terse ("service error"); surface the
// actual SQS error code/message from the error metadata so the real
// cause (throttling, invalid parameter, 5xx, ...) is visible at ERROR
// level without turning on aws-sdk debug logging.
aws_error_code = self.error.code().unwrap_or("unknown"),
aws_error_message = self.error.message().unwrap_or(""),
error_code = "failed_deleting_all_sqs_messages",
error_type = error_type::ACKNOWLEDGMENT_FAILED,
stage = error_stage::PROCESSING,
Expand Down
Loading