Keep regex search working without native PCRE2#107
Merged
Conversation
Gabriel-Darbord
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #106.
PCRE2 remains an MCP baseline dependency and is still loaded automatically. Its Smalltalk package is not optional; only the native runtime library is.
The upstream change in pharo-pcre2#1 detects an absent platform library through UnifiedFFI search paths without exception handling. It must merge first.
This PR delegates MCP availability to that predicate and exercises the normal matcher-selection path when native PCRE2 is unavailable, confirming fallback to Pharo regex matching.
Verification
git diff --check