Skip to content

perf(core): specialize string fingerprint fields and inline separators #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Arbousier1 wants to merge 1 commit into from
Closed

perf(core): specialize string fingerprint fields and inline separators #99

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 34 additions & 22 deletions src/main/java/top/ellan/mahjong/table/core/DelimitedFingerprintBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
package top.ellan.mahjong.table.core;

import java.util.Objects;

public final class DelimitedFingerprintBuilder {
private final StringBuilder delegate;
private boolean needsSeparator;
Expand All @@ -14,28 +12,53 @@ public static DelimitedFingerprintBuilder create(int capacity) {
return new DelimitedFingerprintBuilder(capacity);
}

public DelimitedFingerprintBuilder field(String value) {
if (this.needsSeparator) {
this.delegate.append(':');
}
if (value != null) {
this.delegate.append(value);
}
this.needsSeparator = true;
return this;
}

public DelimitedFingerprintBuilder field(Object value) {
this.appendFieldSeparator();
this.delegate.append(Objects.toString(value, ""));
return this.finishField();
if (this.needsSeparator) {
this.delegate.append(':');
}
if (value != null) {
this.delegate.append(value);
}
this.needsSeparator = true;
return this;
}

public DelimitedFingerprintBuilder field(boolean value) {
this.appendFieldSeparator();
if (this.needsSeparator) {
this.delegate.append(':');
}
this.delegate.append(value);
return this.finishField();
this.needsSeparator = true;
return this;
}

public DelimitedFingerprintBuilder field(char value) {
this.appendFieldSeparator();
if (this.needsSeparator) {
this.delegate.append(':');
}
this.delegate.append(value);
return this.finishField();
this.needsSeparator = true;
return this;
}

public DelimitedFingerprintBuilder field(int value) {
this.appendFieldSeparator();
if (this.needsSeparator) {
this.delegate.append(':');
}
this.delegate.append(value);
return this.finishField();
this.needsSeparator = true;
return this;
}

public DelimitedFingerprintBuilder raw(Object value) {
Expand All @@ -49,17 +72,6 @@ public DelimitedFingerprintBuilder entrySeparator() {
return this;
}

private void appendFieldSeparator() {
if (this.needsSeparator) {
this.delegate.append(':');
}
}

private DelimitedFingerprintBuilder finishField() {
this.needsSeparator = true;
return this;
}

@Override
public String toString() {
return this.delegate.toString();
Expand Down
Loading