Skip to content

fix(ci): make release promotion skip-proof#94

Merged
Arbousier1 merged 1 commit into
devfrom
codex/fix-release-trigger
Jul 16, 2026
Merged

fix(ci): make release promotion skip-proof#94
Arbousier1 merged 1 commit into
devfrom
codex/fix-release-trigger

Conversation

@Arbousier1

Copy link
Copy Markdown
Collaborator

Root cause

GitHub skips pull_request workflows when the pull request HEAD commit contains a CI skip marker. The validated #93 merge intentionally used [skip ci], so closing the subsequent dev-to-main promotion did not create the Release run.

Fix

  • trigger the release promotion gate with pull_request_target: closed
  • retain the existing strict guard: merged, same repository, head dev, base main
  • keep build jobs read-only; contents: write remains isolated to the final trusted release job

GitHub documents pull_request_target: closed as the merge trigger and explicitly states that CI skip annotations do not suppress pull_request_target runs.

Validation

  • independent security review found no must-fix or untrusted-write-token path
  • git diff --check passed
  • no local build was run, per repository validation policy

@Arbousier1
Arbousier1 merged commit b35d475 into dev Jul 16, 2026
5 of 9 checks passed
@Arbousier1
Arbousier1 deleted the codex/fix-release-trigger branch July 16, 2026 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant