Skip to content

perf(runtime): cache Folia global and region scheduler instances #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Arbousier1 wants to merge 1 commit into from
Closed

perf(runtime): cache Folia global and region scheduler instances #105

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions src/main/java/top/ellan/mahjong/runtime/ServerScheduler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,8 @@ public boolean isCancelled() {
};

private final Plugin plugin;
private volatile Object cachedGlobalRegionScheduler;
private volatile Object cachedRegionScheduler;

public ServerScheduler(Plugin plugin) {
this.plugin = Objects.requireNonNull(plugin, "plugin");
Expand Down Expand Up @@ -313,11 +315,27 @@ public PluginTask removeEntity(Entity entity, long delayTicks) {
}

private Object globalRegionScheduler() {
return this.invokeNoArgs(this.plugin.getServer(), GET_GLOBAL_REGION_SCHEDULER);
Object cached = this.cachedGlobalRegionScheduler;
if (cached != null) {
return cached;
}
Object resolved = this.invokeNoArgs(this.plugin.getServer(), GET_GLOBAL_REGION_SCHEDULER);
if (resolved != null) {
this.cachedGlobalRegionScheduler = resolved;
}
return resolved;
}

private Object regionScheduler() {
return this.invokeNoArgs(this.plugin.getServer(), GET_REGION_SCHEDULER);
Object cached = this.cachedRegionScheduler;
if (cached != null) {
return cached;
}
Object resolved = this.invokeNoArgs(this.plugin.getServer(), GET_REGION_SCHEDULER);
if (resolved != null) {
this.cachedRegionScheduler = resolved;
}
return resolved;
}

private Object entityScheduler(Entity entity) {
Expand Down
Loading