perf(render): bypass synthetic accessors in applyQueue#104
Closed
Arbousier1 wants to merge 1 commit into
Closed
Conversation
applyQueue accessed RegionUpdateQueue's private buckets via the bucketCount() and bucket(int) synthetic accessor methods that javac generates for private-inner-class field access. Read the buckets array field directly instead, eliminating two synthetic method calls per queue application. The field is reachable without accessors because RegionUpdateQueue is a private inner class of the same top-level class. Behavior is unchanged: the iteration order, early-return on deferred action, and QueueExecution result are all identical.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Arbousier1
added
performance-ab
Collaborator
Author
|
Closing: AB gate returned INCONCLUSIVE_NOISE_OR_NO_GAIN. Bypassing synthetic accessors in applyQueue did not meet the 3% median improvement threshold. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bypass synthetic accessor methods in
TableRegionDisplayCoordinator.applyQueueby reading theRegionUpdateQueue.bucketsarray field directly.Changes
applyQueuepreviously calledupdates.bucketCount()andupdates.bucket(bucketIndex), which are synthetic accessor methods generated by javac for private-inner-class field access. Readupdates.bucketsdirectly instead, eliminating two synthetic method calls per queue application.Behavior equivalence
QueueExecutionresult are all identical.RegionUpdateQueueis a private inner class of the same top-level class, so thebucketsfield is reachable without accessors.Verification
Target the
region-queueperformance profile (RegionUpdateQueueBenchmark.orderRepresentativeTableRegions).Labels:
performance-ab,performance-region-queue