Optimize watcher shifts and CraftEngine light batches#6
Merged
Conversation
Arbousier1
marked this pull request as ready for review
July 19, 2026 02:28
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Set.copyOfper flushWhy
The existing follow-up paths still rebuilt complete watcher windows on every adjacent chunk crossing and allocated an immutable light snapshot for every CraftEngine batch. These are small, independent allocation optimizations that preserve existing behavior and configuration semantics.
Validation
gradlew check --no-daemon --console=plainRemaining performance gate
A real CraftEngine installation is required for the light-path runtime A/B; this PR does not claim that unavailable measurement. The planned CraftEngine-native renderer and dropped-item index remain separate large factors.