Skip to content

Add windows support for detectord#34

Merged
dimitriosGX merged 2 commits into
mainfrom
dk-quar2
Jul 13, 2026
Merged

Add windows support for detectord#34
dimitriosGX merged 2 commits into
mainfrom
dk-quar2

Conversation

@dimitriosGX

@dimitriosGX dimitriosGX commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Summary by cubic

Adds Windows support for the detector daemon. We package edison-detectord.exe, use a per-user named pipe on Windows, and gate the daemon to macOS/Windows while other platforms keep the TS pipeline.

  • New Features

    • Package the daemon on Windows: scripts/build-detectord-win.sh cross-builds x64/arm64 with zig + cargo-zigbuild; npm run build:win runs it; electron-builder bundles to resources/bin/edison-detectord.exe.
    • Windows IPC uses \\.\pipe\edison-detectord.<user>; on non-macOS/Windows, the app skips daemon bootstrap/primary mode and uses the TS pipeline.
    • Uninstaller stops and purges the detector service and wipes its data.
  • Migration

    • To build Windows installers from macOS/Linux, install zig and cargo-zigbuild.

Written for commit 796ba8e. Summary will update on new commits.

Review in cubic

@qodo-code-review

Copy link
Copy Markdown

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 7 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread src/main/detectord/mode.ts
Comment thread package.json
@dimitriosGX dimitriosGX requested a review from IliaMManolov July 13, 2026 18:20
@dimitriosGX dimitriosGX merged commit f747b41 into main Jul 13, 2026
5 checks passed
@dimitriosGX dimitriosGX deleted the dk-quar2 branch July 13, 2026 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant