Add windows support for detectord#34
Merged
Merged
Conversation
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
There was a problem hiding this comment.
All reported issues were addressed across 7 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Adds Windows support for the detector daemon. We package
edison-detectord.exe, use a per-user named pipe on Windows, and gate the daemon to macOS/Windows while other platforms keep the TS pipeline.New Features
scripts/build-detectord-win.shcross-builds x64/arm64 withzig+cargo-zigbuild;npm run build:winruns it;electron-builderbundles toresources/bin/edison-detectord.exe.\\.\pipe\edison-detectord.<user>; on non-macOS/Windows, the app skips daemon bootstrap/primary mode and uses the TS pipeline.Migration
zigandcargo-zigbuild.Written for commit 796ba8e. Summary will update on new commits.