Update CreditCard Validation class#912
Conversation
Update documentation Add additional self tests Add tests to verify canonicalization output
|
Hi Everyone, I could not get ESAPI to build on Fedora 44 with OpenJDK 25. There were too many runtime errors. They seemed to be related to reflection. I see "Java CI with Maven" in the CI/CD pipeline is having trouble, too. I was hoping to use ESAPI/GitHub pipeline to perform the testing. |
This is presently expected. Java 8 is needed for compatibility with the reflection utilities presently used to test the heavily used singleton state in this baseline. We have been debating newer versions of Java, and associated tool updates; however, that path is not yet fully fleshed out. |
|
One thing I forgot to mention in the first comment... I could not tell what the canonical form is for a Credit Card number. I got lost when trying to find the behavior in the Encoder (and I was not able to run the code to see it in action). I deduced the canonical form from the regex of If someone can verify the canonicalized form for a credit card number, that would be super helpful. |
Update documentation
Add additional self tests
Add tests to verify canonicalization output