Skip to content

Fix Backend (Go) CI guard failure from forbidden ElevenLabs endpoint literal in tests - #1

Merged
EPW80 merged 2 commits into
mainfrom
copilot/fix-backend-go-actions-job
Aug 1, 2026
Merged

Fix Backend (Go) CI guard failure from forbidden ElevenLabs endpoint literal in tests#1
EPW80 merged 2 commits into
mainfrom
copilot/fix-backend-go-actions-job

Conversation

Copilot AI commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

The Backend (Go) GitHub Actions job failed before build/test execution because the CI guard that blocks live ElevenLabs endpoint usage in tests matched a literal endpoint string in a test comment. This PR removes that false-positive trigger without changing test behavior.

  • Root cause (CI guard trip)

    • ci.yml enforces:
      grep -rn "api.elevenlabs.io" pkg/briefing/*_test.go
    • A comment in backend/pkg/briefing/tts_test.go contained that exact literal, causing the guard to fail the job.
  • Change made (minimal/surgical)

    • Reworded the ttsServer helper comment in backend/pkg/briefing/tts_test.go to preserve intent (tests must not call live ElevenLabs) while removing the forbidden literal string.
  • Behavioral impact

    • No production code changes.
    • No test logic changes.
    • Only comment text was updated to comply with the CI guard.

Copilot AI changed the title [WIP] Fix failing GitHub Actions job Backend (Go) Fix Backend (Go) CI guard failure from forbidden ElevenLabs endpoint literal in tests Aug 1, 2026
Copilot AI requested a review from EPW80 August 1, 2026 06:37
@EPW80
EPW80 marked this pull request as ready for review August 1, 2026 06:51
Copilot AI review requested due to automatic review settings August 1, 2026 06:51
@EPW80
EPW80 merged commit b35b484 into main Aug 1, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a false-positive failure in the “Backend (Go)” CI guard that blocks live ElevenLabs usage in tests by rewording a test helper comment to avoid the forbidden api.elevenlabs.io literal, without changing any test behavior.

Changes:

  • Reworded the ttsServer helper comment in backend/pkg/briefing/tts_test.go to remove the literal endpoint string that CI greps for.
  • Preserved the intent of the comment (tests must not make outbound calls to ElevenLabs).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants