[NON-MODULAR] get_lobby_icon now is properly set to the HUD overwrite file#1132
Open
SylvetteSylph wants to merge 2 commits into
Open
[NON-MODULAR] get_lobby_icon now is properly set to the HUD overwrite file#1132SylvetteSylph wants to merge 2 commits into
SylvetteSylph wants to merge 2 commits into
Conversation
Collaborator
|
why is this still in draft?> |
Author
felt weird about not being able to test it |
SylvetteSylph
marked this pull request as ready for review
July 11, 2026 00:15
SylvetteSylph
requested review from
00-Steven and
carda-sometimesknownas-paxilmaniac
as code owners
July 11, 2026 00:15
00-Steven
requested changes
Jul 17, 2026
| CRASH("[src.type] has no job icon state.") | ||
|
|
||
| return icon('icons/mob/huds/hud.dmi', icon_state) | ||
| return icon('modular_doppler/overwrites/huds/hud.dmi', icon_state) // DOPPLER EDIT CHANGE, ensuring job icon selected is the Doppler version, ORIGINAL: 'icons/mob/huds/hud.dmi' |
Collaborator
There was a problem hiding this comment.
Suggested change
| return icon('modular_doppler/overwrites/huds/hud.dmi', icon_state) // DOPPLER EDIT CHANGE, ensuring job icon selected is the Doppler version, ORIGINAL: 'icons/mob/huds/hud.dmi' | |
| return icon('modular_doppler/overwrites/huds/hud.dmi', icon_state) // DOPPLER EDIT CHANGE, ensuring job icon selected is the Doppler version, ORIGINAL: return icon('modular_doppler/overwrites/huds/hud.dmi', icon_state) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hate GitHub with a burning passion.
About The Pull Request
The
get_lobby_iconproc was reading theicon_statefromicons/mob/huds/hud.dmi, when we want it to be using the overwrite files. Now, it shall read frommodular_doppler/overwrites/huds/hud.dmidirectly.Why It's Good For The Game
Using the correct icons is generally preferable.
Testing Evidence
I need to find some way to actually consistently get Psychologist as an overflow job to test this.
Changelog
🆑
fix: We are now using the overwrite HUD for lobby icons.
/:cl: