Conversation
DanDits
reviewed
Aug 6, 2026
DanDits
reviewed
Aug 6, 2026
Collaborator
|
Looks fine, I like having the two options and an easy switch so local development is not affected. Looks like you tried to work around some gunicorn quirks at best effort. Do the mentioned non-json lines that might be logged bother a potential json-expecting log consumer? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal: Make cadenzaanalytics logging configurable to emit Elastic Common Schema (ECS) JSON, suitable for container log aggregation, covering the library itself, dependent packages, and analytics extension code — with minimal burden on extension developers.
Changes:
src/cadenzaanalytics/logging_config.pyCadenzaEcsFormatteras subclass ofecs_logging.StdlibFormatterand stamping every record with service.name/service.versiongunicorn.error/gunicorn.accessat the same handler