Export associated images - #335
Open
cooperlab wants to merge 23 commits into
Open
Conversation
Update fork
Author
|
Typing error are being raised for the IFD argument below. I'm not clear how the original code was handling this so I was hesitant to try to fix. Everything else is passing.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the option to export associated images (label, macro, and thumbnail) to the cli and api. Core facilities that offer deidentification services may require the provenance provided by the label images, and may need to review thumbnails to confirm no PHI leakage into the image pyramid. The thumbnails are also helpful to the receiver of the data to organize and sort the deidentified images.
Refactoring was done to the utilities so that associated images can be accessed from within redact.py and to eliminate other circular imports.
To discuss:
The associated images are currently deposited in an "associated" subfolder within the output folder. There is risk of PHI disclosure if these are transferred to the recipient. May need a different location, or to more clearly label which folders do/not presumably contain PHI.