Restrict groups - #539
Open
bnmajor wants to merge 9 commits into
Open
Conversation
bnmajor
force-pushed
the
restrict-groups
branch
from
August 4, 2026 20:30
42e6086 to
36987d6
Compare
bnmajor
force-pushed
the
restrict-groups
branch
from
August 5, 2026 14:21
36987d6 to
f66543d
Compare
bnmajor
force-pushed
the
restrict-groups
branch
from
August 5, 2026 14:31
fa442b1 to
8e5aadc
Compare
Assign `originalAnnotation` on the model before it enters the collection so the menu reflects the clicked annotation rather than the panel selection.
…tion - Context menu auto-creates a restricted annotation's allowed groups the first time it encounters them - Regression test asserting context menu renders clicked annotation's restriction on selection rather than the active annotation in the panel
bnmajor
force-pushed
the
restrict-groups
branch
from
August 5, 2026 15:24
4b5e7da to
2eeb0dd
Compare
bnmajor
marked this pull request as ready for review
August 5, 2026 15:25
Contributor
|
We'll need to add to the documentation somewhere for this, too. |
Contributor
|
I guess we should add a new file to the docs directory (and, as a separate PR, we really should have links to the docs in the docs directory from somewhere). This works well in my testing. I wonder if we should accept both a proper JSON array AND a flat string (e.g., |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.