Doppio live processing requirements - #790
Merged
Merged
Conversation
… resubscribe to transport object
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #790 +/- ##
==========================================
- Coverage 54.89% 53.83% -1.07%
==========================================
Files 104 104
Lines 11259 11673 +414
Branches 1490 1617 +127
==========================================
+ Hits 6181 6284 +103
- Misses 4753 5039 +286
- Partials 325 350 +25 🚀 New features to boost your workflow:
|
stephen-riggs
marked this pull request as ready for review
August 14, 2026 15:18
Collaborator
|
I've had a good look over and I feel pretty happy with it! I had forgotten how many changes had been made overall. As discussed on Friday the logic for the paths in processing_params.py will need looking at, and further testing for the job reservation system... I'll have another look at this soon. |
tieneupin
reviewed
Aug 17, 2026
tieneupin
reviewed
Aug 17, 2026
tieneupin
reviewed
Aug 17, 2026
tieneupin
reviewed
Aug 17, 2026
tieneupin
reviewed
Aug 17, 2026
tieneupin
reviewed
Aug 18, 2026
tieneupin
reviewed
Aug 18, 2026
tieneupin
reviewed
Aug 18, 2026
tieneupin
reviewed
Aug 18, 2026
tieneupin
reviewed
Aug 18, 2026
tieneupin
reviewed
Aug 18, 2026
tieneupin
approved these changes
Aug 19, 2026
tieneupin
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me now. Nice work! 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Various changes are needed for doppio-live to work.
These are primarily connected to the job number assigned, as we need to be able to vary these if the default pipeline file is being changed by a user. For eBIC operations, the behaviour should be as before, but for doppio-live the jobs are assigned properly using ccpem-pipeliner.
Changes are also needed for the output motion corrected mrc file. The output path for doppio uses the pipeline star file to find a suitable job number. It currently does not include the GridSquare folder so may need changing again in future. The behaviour at eBIC should be unchanged.
Other bits:
picker_murfey_idfrom the database tablesmurfey.serverand not the_transport_objectdirectly