Skip to content

Doppio live processing requirements - #790

Merged
stephen-riggs merged 32 commits into
mainfrom
doppio-live-processing
Aug 19, 2026
Merged

Doppio live processing requirements#790
stephen-riggs merged 32 commits into
mainfrom
doppio-live-processing

Conversation

@stephen-riggs

@stephen-riggs stephen-riggs commented Apr 27, 2026

Copy link
Copy Markdown
Contributor

Various changes are needed for doppio-live to work.

These are primarily connected to the job number assigned, as we need to be able to vary these if the default pipeline file is being changed by a user. For eBIC operations, the behaviour should be as before, but for doppio-live the jobs are assigned properly using ccpem-pipeliner.

Changes are also needed for the output motion corrected mrc file. The output path for doppio uses the pipeline star file to find a suitable job number. It currently does not include the GridSquare folder so may need changing again in future. The behaviour at eBIC should be unchanged.

Other bits:

  • Removes the picker_murfey_id from the database tables
  • Standardise to import murfey.server and not the _transport_object directly
  • Typing hints

Comment thread src/murfey/util/processing_params.py Dismissed
Comment thread src/murfey/util/processing_params.py Fixed
Comment thread src/murfey/util/processing_params.py Fixed
Comment thread src/murfey/server/api/workflow.py Fixed
Comment thread src/murfey/util/processing_params.py Fixed
Comment thread src/murfey/util/processing_params.py Fixed
Comment thread src/murfey/util/processing_params.py Fixed
Comment thread src/murfey/util/processing_params.py Dismissed
Comment thread src/murfey/util/processing_params.py Dismissed
@codecov

codecov Bot commented Jul 17, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 40.29851% with 200 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.83%. Comparing base (94ea29d) to head (a1ed499).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #790      +/-   ##
==========================================
- Coverage   54.89%   53.83%   -1.07%     
==========================================
  Files         104      104              
  Lines       11259    11673     +414     
  Branches     1490     1617     +127     
==========================================
+ Hits         6181     6284     +103     
- Misses       4753     5039     +286     
- Partials      325      350      +25     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stephen-riggs
stephen-riggs marked this pull request as ready for review August 14, 2026 15:18
@Koldstream

Copy link
Copy Markdown
Collaborator

I've had a good look over and I feel pretty happy with it! I had forgotten how many changes had been made overall.

As discussed on Friday the logic for the paths in processing_params.py will need looking at, and further testing for the job reservation system... I'll have another look at this soon.

Comment thread src/murfey/util/processing_params.py Outdated
Comment thread src/murfey/server/api/workflow.py Outdated
Comment thread src/murfey/server/api/workflow.py Outdated
Comment thread src/murfey/server/api/session_info.py Outdated
Comment thread src/murfey/server/api/workflow.py Outdated
Comment thread src/murfey/server/api/workflow.py Outdated
Comment thread src/murfey/server/api/workflow.py Outdated
Comment thread src/murfey/server/api/workflow.py Outdated
Comment thread src/murfey/server/api/workflow.py Outdated
Comment thread src/murfey/server/api/workflow.py
Comment thread tests/workflows/fib/test_register_atlas.py Outdated

@tieneupin tieneupin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now. Nice work! 👍

@stephen-riggs
stephen-riggs merged commit 8aee927 into main Aug 19, 2026
14 checks passed
@stephen-riggs
stephen-riggs deleted the doppio-live-processing branch August 19, 2026 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants