feat(example): adds additional example, a visr recon workflow. - #34
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #34 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 12 12
=========================================
Hits 12 12 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
9311983 to
decdb6f
Compare
decdb6f to
fcf90b4
Compare
JamesDoingStuff
left a comment
There was a problem hiding this comment.
Looks like a good example and well-annotated. I've got a couple questions and suggestions in the code, just minor things.
I think if the docs/instructions are going to be comments in the code then it'd also be good to have some kind of index in the readme that lets users know where the examples are found and what each one shows. That should be a separate PR though
There was a problem hiding this comment.
I think this and the jinja-templated workflows need updating to get the new changes - let me know once you've done that and I'll approve 👍
There was a problem hiding this comment.
Oh woops yes they do thank you! Done the jinja templated notebook but yes, forgot about those two, thank you!
JamesDoingStuff
left a comment
There was a problem hiding this comment.
You've got a typo in your last commit message btw, should probably amend
4dcba67 to
70bf2d7
Compare
No description provided.