Skip to content

feat(example): adds additional example, a visr recon workflow. - #34

Merged
Matt-Carre merged 5 commits into
mainfrom
real_example
Aug 20, 2026
Merged

feat(example): adds additional example, a visr recon workflow.#34
Matt-Carre merged 5 commits into
mainfrom
real_example

Conversation

@Matt-Carre

Copy link
Copy Markdown
Collaborator

No description provided.

@Matt-Carre
Matt-Carre requested a review from TBThomas56 August 17, 2026 09:53
@codecov

codecov Bot commented Aug 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (f8f38cd) to head (70bf2d7).

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #34   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           12        12           
=========================================
  Hits            12        12           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Matt-Carre
Matt-Carre force-pushed the real_example branch 2 times, most recently from 9311983 to decdb6f Compare August 17, 2026 09:56

@JamesDoingStuff JamesDoingStuff left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good example and well-annotated. I've got a couple questions and suggestions in the code, just minor things.

I think if the docs/instructions are going to be comments in the code then it'd also be good to have some kind of index in the readme that lets users know where the examples are found and what each one shows. That should be a separate PR though

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this and the jinja-templated workflows need updating to get the new changes - let me know once you've done that and I'll approve 👍

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh woops yes they do thank you! Done the jinja templated notebook but yes, forgot about those two, thank you!

@JamesDoingStuff JamesDoingStuff left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've got a typo in your last commit message btw, should probably amend

@Matt-Carre
Matt-Carre merged commit 01611a0 into main Aug 20, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants