[debug] solve TYPE_CHECKING problem in shape.py#335
Open
wuxinxin27 wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a runtime crash in ShapeCfg.from_dict when visual_material is provided as a dict by importing VisualMaterialCfg at runtime (instead of only under TYPE_CHECKING). This aligns ShapeCfg.from_dict behavior with how config dicts are used when constructing objects (e.g., via RigidObjectCfg.from_dict).
Changes:
- Add a local runtime import of
VisualMaterialCfginsideShapeCfg.from_dictwhen parsingvisual_materialfrom a dict.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
79
to
+84
| for key, value in init_dict.items(): | ||
| if hasattr(cfg, key): | ||
| attr = getattr(cfg, key) | ||
| if key == "visual_material" and isinstance(value, dict): | ||
| from embodichain.lab.sim.material import VisualMaterialCfg | ||
|
|
yuecideng
approved these changes
Jun 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, the
VisualMaterialCfgtype inshape.pyis imported only for static type checking and not at runtime; however, theShapeCfg.from_dictfunction usesVisualMaterialCfg, resulting in a runtime error.Fixes # (issue)
Simply import VisualMaterialCfg inside the ShapeCfg.from_dict function.
Type of change
Checklist
black .command to format the code base.