ci(xtask): add dependency-invariant guard for ironrdp-session#1438
Merged
Benoît Cortier (CBenoit) merged 2 commits intoJul 10, 2026
Merged
Conversation
Add `cargo xtask check dependencies`, asserting `ironrdp-session` has no transitive (non-dev) edge to `ironrdp-connector` or `sspi`. Each forbidden `(package, banned)` pair is checked via `cargo tree -p <pkg> -e no-dev -i <banned>`: a successful, non-empty output means the edge is present and fails the check. This locks the invariant introduced in #1423 so decode-only consumers can depend on `ironrdp-session` alone with the slim graph, without it regressing. The guard runs in the CI `checks` job and is included in the `ci` sweep. Closes #1424
There was a problem hiding this comment.
Pull request overview
Adds an xtask guard preserving ironrdp-session’s slim dependency graph.
Changes:
- Adds
check dependenciesCLI support. - Checks forbidden non-dev dependency edges.
- Runs the guard in CI and the full xtask sweep.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
xtask/src/check.rs |
Implements dependency invariant checks. |
xtask/src/cli.rs |
Exposes the new command. |
xtask/src/main.rs |
Dispatches and includes the check in CI. |
.github/workflows/ci.yml |
Runs the check across CI platforms. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Vladyslav Nikonov (vnikonov-devolutions)
approved these changes
Jul 10, 2026
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Marc-André Moreau (mamoreau-devolutions)
approved these changes
Jul 10, 2026
Benoît Cortier (CBenoit)
deleted the
chore/dependency-invariant-xtask-guard
branch
July 10, 2026 13:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
cargo xtask check dependencies, assertingironrdp-sessionhas no transitive (non-dev) edge toironrdp-connectororsspi. Each forbidden(package, banned)pair is checked viacargo tree -p <pkg> -e no-dev -i <banned>: a successful, non-empty output means the edge is present and fails the check.This locks the invariant introduced in #1423 so decode-only consumers can depend on
ironrdp-sessionalone with the slim graph, without it regressing.The guard runs in the CI
checksjob and is included in thecisweep.Closes #1424