Fix approval notification toast: placement, coverage, and wording - #5
Merged
Conversation
The cross-agent "Approval required" toast (shown when an agent you're not looking
at needs approval) was unreliable and unclear. Three fixes:
- Placement: the toast spanned only the rail + the collapsible Snapshots column,
so it was clipped to the rail's edge unless the Snapshots panel happened to be
open (making it look attached to Snapshots). It now spans the full window and
anchors to the true top-right, visible on every screen.
- Coverage: an approval in the SELECTED agent while you were on Settings/MCP/
Appearance raised no toast (the toast only targeted non-selected tabs) and the
chat — and the approval — is collapsed on those screens, so you saw nothing.
The toast now fires for any approval you can't currently see, and page changes
re-evaluate it.
- Wording: the toast echoed the modal's question ("Apply these changes?", "What
would you like to do?"). It now shows a specific, third-person summary of what's
waiting — "Wants to edit Program.cs", "Wants to run a proposed plan", "Wants to
run: <cmd>", "Wants to delete <file>", "Wants to run tool <name>" — via a new
ApprovalRequest.ToastSummary.
Covers diff, command, delete, MCP, and plan approvals.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this fixes
The cross-agent "Approval required" notification — the toast that's supposed to appear when an agent you're not currently looking at needs your approval (a file change, a command, a proposed plan) — was unreliable and unclear. Users could miss approvals entirely, or see a broken sliver of the notification. Three related problems, all fixed.
Why it matters
Approvals block an agent until you respond. If the notification doesn't reliably tell you that one is waiting, which agent, and what it wants, agents silently stall and you don't know why. This makes the notification actually dependable.
What was wrong (and what's fixed)
1. The notification was mispositioned
2. You got no notification if the agent you had selected needed approval while you were on Settings / MCP / Appearance
3. The notification text was unhelpful
<file><file><command><file><tool>"Scope, risk, and testing
🤖 Generated with Claude Code