Skip to content

Fix approval notification toast: placement, coverage, and wording - #5

Merged
DevMando merged 1 commit into
mainfrom
fix/approval-toast-placement
Jul 16, 2026
Merged

Fix approval notification toast: placement, coverage, and wording#5
DevMando merged 1 commit into
mainfrom
fix/approval-toast-placement

Conversation

@DevMando

Copy link
Copy Markdown
Owner

What this fixes

The cross-agent "Approval required" notification — the toast that's supposed to appear when an agent you're not currently looking at needs your approval (a file change, a command, a proposed plan) — was unreliable and unclear. Users could miss approvals entirely, or see a broken sliver of the notification. Three related problems, all fixed.

Why it matters

Approvals block an agent until you respond. If the notification doesn't reliably tell you that one is waiting, which agent, and what it wants, agents silently stall and you don't know why. This makes the notification actually dependable.

What was wrong (and what's fixed)

1. The notification was mispositioned

  • It appeared only as a thin sliver clipped to the left edge, and became fully visible only when the "Context Snapshots" panel was open — where it overlapped that panel, looking like it belonged to it.
  • Cause: it was pinned to the left rail + the (usually-collapsed) Snapshots column instead of the whole window.
  • Fixed: it now anchors to the window's top-right and shows correctly on every screen.

2. You got no notification if the agent you had selected needed approval while you were on Settings / MCP / Appearance

  • Those screens hide the chat, so you couldn't see the approval — and the toast didn't fire because it only watched other (non-selected) agents.
  • Fixed: the toast now fires for any approval you can't currently see (including your selected agent while you're off the chat screen), and it clears when you return. Clicking it takes you straight to that agent's chat.

3. The notification text was unhelpful

  • It echoed the approval dialog's question — e.g. "Apply these changes?" or "The assistant proposes this plan. What would you like to do?" — which says nothing about what's actually waiting.
  • Fixed: it now shows a specific, at-a-glance summary of the pending action:
Approval Notification now reads
Proposed plan Wants to run a proposed plan
Edit a file Wants to edit <file>
Create a file Wants to create <file>
Run a command Wants to run: <command>
Delete Wants to delete <file>
MCP tool Wants to run tool "<tool>"

Scope, risk, and testing

  • Scope: desktop UI only (notification placement, when it fires, and its text). No change to what actually gets approved or to the agent engine.
  • Build: compiles clean (0 warnings, 0 errors).
  • Suggested manual check: trigger an approval in a background agent from the chat, Settings, MCP, and Appearance screens; confirm the toast appears top-right, names the right agent, describes the action, and clicking it lands on that agent's chat with the approval visible. Repeat with a proposed plan.

🤖 Generated with Claude Code

The cross-agent "Approval required" toast (shown when an agent you're not looking
at needs approval) was unreliable and unclear. Three fixes:

- Placement: the toast spanned only the rail + the collapsible Snapshots column,
  so it was clipped to the rail's edge unless the Snapshots panel happened to be
  open (making it look attached to Snapshots). It now spans the full window and
  anchors to the true top-right, visible on every screen.

- Coverage: an approval in the SELECTED agent while you were on Settings/MCP/
  Appearance raised no toast (the toast only targeted non-selected tabs) and the
  chat — and the approval — is collapsed on those screens, so you saw nothing.
  The toast now fires for any approval you can't currently see, and page changes
  re-evaluate it.

- Wording: the toast echoed the modal's question ("Apply these changes?", "What
  would you like to do?"). It now shows a specific, third-person summary of what's
  waiting — "Wants to edit Program.cs", "Wants to run a proposed plan", "Wants to
  run: <cmd>", "Wants to delete <file>", "Wants to run tool <name>" — via a new
  ApprovalRequest.ToastSummary.

Covers diff, command, delete, MCP, and plan approvals.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@DevMando
DevMando merged commit 766516f into main Jul 16, 2026
1 check passed
@DevMando
DevMando deleted the fix/approval-toast-placement branch July 17, 2026 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant