Fix: picking Sequoia Trail or Pismo Beach still showed Golden Gate - #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In Settings → Appearance, choosing the Sequoia Trail or Pismo Beach background tile appeared to do nothing — the chat kept showing Golden Gate no matter which tile was selected. This PR fixes that with a one-line change.
What was wrong
When a background is picked, the app copies the image into the user's data folder and tells the chat view to load it with a small version stamp on the URL, so the view knows to fetch the new picture instead of reusing an old one. That version stamp comes from the image file's timestamp — but the copy step preserves the original file's timestamp, and all three bundled backgrounds happen to share the exact same one (they were written to disk in a single download). As a result, every gallery pick produced an identical URL, and the chat view kept serving the first image it had cached: Golden Gate. The selection itself was being saved correctly — only the on-screen picture was stale.
What changed
After copying the chosen image, the app now stamps the copy with the current time. Every pick therefore gets a fresh URL and the chat view fetches the right picture immediately. This also protects user-supplied images that could hit the same coincidence.
Scope and risk
ThemeManager.cs), five lines added, no behavior changes beyond the fix.How to verify