Grids: decouple dataController from kbn - #34849
Merged
anna-shakhova merged 2 commits intoAug 20, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors Grid Core dependencies to reduce coupling between the base DataController / EditorFactory and the keyboardNavigation controller, moving that dependency into the focus module’s extenders where it’s actually needed.
Changes:
- Removed
keyboardNavigationcontroller wiring fromEditorFactoryandDataControllerbase implementations. - Added focus-specific extenders that initialize and store
keyboardNavigationcontroller references inm_focus.ts. - Updated the focus module extender registration to use the new extender functions.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
packages/devextreme/js/__internal/grids/grid_core/focus/m_focus.ts |
Adds init() to focus-related extenders to obtain keyboardNavigation and updates extender registration. |
packages/devextreme/js/__internal/grids/grid_core/editor_factory/m_editor_factory.ts |
Removes unused keyboardNavigation controller field/import/initialization from EditorFactory. |
packages/devextreme/js/__internal/grids/grid_core/data_controller/data_controller.ts |
Removes unused keyboardNavigation controller field/import/initialization from DataController. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Alyar666
requested changes
Aug 20, 2026
Alyar666
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.