GridCore data: Relocate _editingController to editing data-extenders - #34832
Open
bit-byte0 wants to merge 2 commits into
Open
GridCore data: Relocate _editingController to editing data-extenders#34832bit-byte0 wants to merge 2 commits into
bit-byte0 wants to merge 2 commits into
Conversation
bit-byte0
force-pushed
the
refactor/gridcore-relocate-editing-controller-26_2
branch
from
August 19, 2026 10:23
1cf9ad8 to
2cae359
Compare
bit-byte0
force-pushed
the
refactor/gridcore-relocate-editing-controller-26_2
branch
from
August 20, 2026 07:28
2cae359 to
3f9cd9f
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors GridCore editing DataController extensions by moving editing-related DataController extender logic into dedicated files under editing/extenders/, while keeping module wiring intact. This aligns the editing feature with the grid module extender pattern and isolates mode-specific behavior (row-based vs form-based) from the main editing module.
Changes:
- Extracted the main editing DataController extender mixin into
extenders/editing_data_controller.tsand re-exported it fromm_editing.ts. - Moved row-based and form-based DataController extenders into their own files and updated module registrations to reference them.
- Added local
init()resolution of theeditingcontroller in each new data-controller extender.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/devextreme/js/__internal/grids/grid_core/editing/m_editing.ts | Imports the extracted data-controller extender and re-exports it; keeps the editing module’s data extender wiring unchanged. |
| packages/devextreme/js/__internal/grids/grid_core/editing/m_editing_row_based.ts | Replaces the inline row-based DataController extender with an imported extender implementation. |
| packages/devextreme/js/__internal/grids/grid_core/editing/m_editing_form_based.ts | Replaces the inline form-based DataController extender with an imported extender implementation. |
| packages/devextreme/js/__internal/grids/grid_core/editing/extenders/editing_data_controller.ts | New: contains the main editing DataController extender mixin previously defined in m_editing.ts. |
| packages/devextreme/js/__internal/grids/grid_core/editing/extenders/editing_row_based_data_controller.ts | New: contains the row-based DataController extender previously defined inline in m_editing_row_based.ts. |
| packages/devextreme/js/__internal/grids/grid_core/editing/extenders/editing_form_based_data_controller.ts | New: contains the form-based DataController extender previously defined inline in m_editing_form_based.ts. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
|
||
| type EditingCell = Cell & { isEditing?: boolean }; | ||
|
|
||
| export const dataControllerEditingExtenderMixin = ( |
Contributor
There was a problem hiding this comment.
Suggested change
| export const dataControllerEditingExtenderMixin = ( | |
| export const editingDataControllerExtender = ( |
|
|
||
| export const dataControllerEditingExtenderMixin = ( | ||
| Base: ModuleType<DataController>, | ||
| ): ModuleType<DataController> => class DataControllerEditingExtender extends Base { |
Contributor
There was a problem hiding this comment.
Suggested change
| ): ModuleType<DataController> => class DataControllerEditingExtender extends Base { | |
| ): ModuleType<DataController> => class EditingDataControllerExtender extends Base { |
|
|
||
| import type { EditingController } from '../m_editing'; | ||
|
|
||
| export const dataControllerEditingFormBasedExtender = ( |
Contributor
There was a problem hiding this comment.
Suggested change
| export const dataControllerEditingFormBasedExtender = ( | |
| export const editingFormBasedDataControllerExtender = ( |
|
|
||
| export const dataControllerEditingFormBasedExtender = ( | ||
| Base: ModuleType<DataController>, | ||
| ): ModuleType<DataController> => class DataEditingFormBasedExtender extends Base { |
Contributor
There was a problem hiding this comment.
Suggested change
| ): ModuleType<DataController> => class DataEditingFormBasedExtender extends Base { | |
| ): ModuleType<DataController> => class EditingFormBasedDataControllerExtender extends Base { |
|
|
||
| import type { EditingController } from '../m_editing'; | ||
|
|
||
| export const dataControllerEditingRowBasedExtender = ( |
Contributor
There was a problem hiding this comment.
Suggested change
| export const dataControllerEditingRowBasedExtender = ( | |
| export const editingRowBasedDataControllerExtender = ( |
|
|
||
| export const dataControllerEditingRowBasedExtender = ( | ||
| Base: ModuleType<DataController>, | ||
| ): ModuleType<DataController> => class DataEditingRowBasedExtender extends Base { |
Contributor
There was a problem hiding this comment.
Suggested change
| ): ModuleType<DataController> => class DataEditingRowBasedExtender extends Base { | |
| ): ModuleType<DataController> => class EditingRowBasedDataControllerExtender extends Base { |
| import { EDITING_EDITROWKEY_OPTION_NAME } from '../const'; | ||
| import type { EditingController } from '../m_editing'; | ||
|
|
||
| type EditingCell = Cell & { isEditing?: boolean }; |
Contributor
There was a problem hiding this comment.
shouldn't it be shared type?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds local resolution of
_editingControllerin the editing data-controller extenders (m_editing, form-based, row-based)How
Each editing data-extender declares the field and resolves the
editingcontroller in its owninit()