Feature/csb manifest - #34828
Open
vorobey wants to merge 10 commits into
Open
Conversation
vorobey
force-pushed
the
feature/csb-manifest
branch
from
August 19, 2026 08:12
ad7d079 to
f1a90f6
Compare
vorobey
force-pushed
the
feature/remove-systemjs-from-demos
branch
from
August 19, 2026 08:17
302a31b to
3f49784
Compare
vorobey
force-pushed
the
feature/csb-manifest
branch
from
August 19, 2026 08:18
f1a90f6 to
f16d590
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds generation of a per-demo demo.manifest.json intended for CodeSandbox, capturing the npm packages (and peer dependencies) required by each bundled demo, and enhances import scanning/version resolution logic in the server-side bundling utilities.
Changes:
- Extend
vendor-bundle.jsto (a) avoid scanning generated bundle artifacts and (b) resolve imported package versions + required peer dependencies into manifests. - Emit a per-demo
demo.manifest.jsonduring React/Vue and Angular demo bundling. - Update demos
.gitignoreto exclude the generated manifest, and adjust minor workflow/comment formatting.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| apps/demos/utils/server/vendor-bundle.js | Adds robust specifier collection helpers, ignores generated artifacts, and resolves package versions/peers into vendor manifests (plus exports utilities for demo manifests). |
| apps/demos/utils/server/csp-bundle.js | Writes demo.manifest.json for each React/Vue demo after bundling. |
| apps/demos/utils/server/csp-bundle-angular.js | Writes demo.manifest.json for each Angular demo (including implicit packages list). |
| apps/demos/utils/server/build-vendor-bundles.js | Clarifies CLI header comment about Angular vendor bundle limitations. |
| apps/demos/.gitignore | Ignores generated demo.manifest.json in demo source folders. |
| .github/workflows/visual-tests-demos.yml | Removes an extraneous blank line in the workflow YAML. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
vorobey
marked this pull request as ready for review
August 20, 2026 10:13
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.
Suppressed comments (2)
apps/demos/utils/server/csp-bundle.js:20
- The script no longer reads
BUNDLE_IN_PLACE, but CI still sets it (e.g..github/workflows/visual-tests-demos.ymlusesBUNDLE_IN_PLACE: '1'). This env var is now a no-op and may hide configuration mistakes. Consider updating callers to useCSP_BUNDLE_GENERATE_MANIFESTS(if the intent is to emitdemo.manifest.json) and/or removingBUNDLE_IN_PLACEfrom workflows/docs.
const IS_GENERATE_MANIFESTS = process.env.CSP_BUNDLE_GENERATE_MANIFESTS === '1';
apps/demos/utils/server/csp-bundle-angular.js:16
BUNDLE_IN_PLACEsupport appears to have been removed (replaced byCSP_BUNDLE_GENERATE_MANIFESTS), but some automation still setsBUNDLE_IN_PLACE. If this script is invoked directly (or via csp-bundle.js for Angular), that legacy env var will be ignored; update any callers/docs that still rely on it.
const IS_GENERATE_MANIFESTS = process.env.CSP_BUNDLE_GENERATE_MANIFESTS === '1';
const NODE_MODULES = path.join(DEMOS_APP_ROOT, 'node_modules');
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.