Scheduler: fix broken resize in vertical grouping - #34805
Open
sjbur wants to merge 2 commits into
Open
Conversation
sjbur
force-pushed
the
v2_issue-1918_26_2
branch
from
August 18, 2026 13:49
855ddbb to
b5c1888
Compare
sjbur
marked this pull request as ready for review
August 18, 2026 13:51
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
Suppressed comments (1)
packages/devextreme/js/__internal/scheduler/appointments/appointment/m_appointment.ts:289
- This also disables strict snapping for horizontal appointments; all-day items are explicitly assigned
direction: 'horizontal'ingenerate_grid_view_model.ts:87. The unequal all-day row height only disrupts vertical edge alignment, so horizontal all-day resizing should retain strict precision instead of switching to delta-based rounding. Gate this workaround on vertical direction.
const allDayBreaksCellGrid = Boolean(this.invoke('isVerticalGroupedWorkSpace'))
&& allDayHeight > 0
&& allDayHeight !== cellHeight;
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.
Suppressed comments (1)
packages/devextreme/js/__internal/scheduler/m_subscribes.ts:204
- This new workspace dependency is missing from the
SchedulerWorkSpaceLikecontract inscheduler.ts(unlikegetCellHeightandisVerticalGroupedWorkSpace). Because this mixin'sthisis effectively untyped, the omission is not caught here and future workspace implementations can satisfy the interface without providing this method. AddgetAllDayHeight: () => numberto that interface so this call is statically checked.
return this.getWorkSpace().getAllDayHeight();
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.