Skip to content

Scheduler: fix broken resize in vertical grouping - #34805

Open
sjbur wants to merge 2 commits into
DevExpress:mainfrom
sjbur:v2_issue-1918_26_2
Open

Scheduler: fix broken resize in vertical grouping#34805
sjbur wants to merge 2 commits into
DevExpress:mainfrom
sjbur:v2_issue-1918_26_2

Conversation

@sjbur

@sjbur sjbur commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@sjbur sjbur self-assigned this Aug 18, 2026
@sjbur sjbur added the 26_2 label Aug 18, 2026
@sjbur
sjbur force-pushed the v2_issue-1918_26_2 branch from 855ddbb to b5c1888 Compare August 18, 2026 13:49
@sjbur
sjbur marked this pull request as ready for review August 18, 2026 13:51
Copilot AI balanced review requested due to automatic review settings August 18, 2026 13:51
@sjbur
sjbur requested a review from a team as a code owner August 18, 2026 13:51

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@sjbur
sjbur requested a balanced review from Copilot August 18, 2026 13:54

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

Suppressed comments (1)

packages/devextreme/js/__internal/scheduler/appointments/appointment/m_appointment.ts:289

  • This also disables strict snapping for horizontal appointments; all-day items are explicitly assigned direction: 'horizontal' in generate_grid_view_model.ts:87. The unequal all-day row height only disrupts vertical edge alignment, so horizontal all-day resizing should retain strict precision instead of switching to delta-based rounding. Gate this workaround on vertical direction.
    const allDayBreaksCellGrid = Boolean(this.invoke('isVerticalGroupedWorkSpace'))
      && allDayHeight > 0
      && allDayHeight !== cellHeight;

Comment thread packages/devextreme/js/__internal/scheduler/workspaces/work_space.ts Outdated
Copilot AI review requested due to automatic review settings August 18, 2026 14:48

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

Suppressed comments (1)

packages/devextreme/js/__internal/scheduler/m_subscribes.ts:204

  • This new workspace dependency is missing from the SchedulerWorkSpaceLike contract in scheduler.ts (unlike getCellHeight and isVerticalGroupedWorkSpace). Because this mixin's this is effectively untyped, the omission is not caught here and future workspace implementations can satisfy the interface without providing this method. Add getAllDayHeight: () => number to that interface so this call is statically checked.
    return this.getWorkSpace().getAllDayHeight();

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants