Skip to content

fix(agentic): sanitize safety prompt details and clean host-visible upstream errors #921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dembrane-sam-bot wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(agentic): sanitize safety prompt details and clean host-visible upstream errors #921

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
31f0389
fix(agentic): sanitize safety prompt details and clean host-visible u…
dembrane-sam-bot Jul 30, 2026
21ad2a0
fix(agentic): send the error code to the host, never the upstream text
spashii Jul 30, 2026
4fe5a3f
chore: merge origin/main to resolve i18n/locale compilation conflicts
dembrane-sam-bot Jul 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 15 additions & 7 deletions echo/frontend/src/components/chat/AgenticChatPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,20 @@ const AGENTIC_REFERENCE_LIST_PATTERN = /\[conversation_ids?:\s*([^\]]+)\]/g;

const LOOKS_LIKE_ID_PATTERN = /^[0-9a-f][0-9a-f-]{7,}$/i;

// A failed run tells us a code, never prose: the server deliberately withholds
// upstream error text, which is unbounded, untranslated and can echo the prompt
// back at us. The wording is ours and lives here so it is localised.
const runFailureMessage = (errorCode: unknown): string => {
switch (errorCode) {
case "AGENT_CANCELLED":
return t`You stopped this run.`;
case "AGENT_TIMEOUT":
return t`This request took too long, so I stopped it. Send it again and I'll retry.`;
default:
return t`Something went wrong on my side. Send your message again and I'll retry.`;
}
};

const buildTranscriptLink = ({
chunkId,
conversationId,
Expand Down Expand Up @@ -305,13 +319,7 @@ const toMessage = ({

if (event.event_type === "run.failed" || event.event_type === "run.timeout") {
return {
content: enrichAgenticContent({
content: content ?? t`Agent run failed`,
conversationNames,
language,
projectId,
workspaceId,
}),
content: runFailureMessage(payload?.error_code),
id: `a-${event.seq}`,
role: "assistant",
sortSeq: event.seq,
Expand Down
Loading
Loading