Generalize inlet coordinates and flow direction#324
Open
elbeejay wants to merge 6 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #324 +/- ##
===========================================
+ Coverage 91.47% 91.51% +0.03%
===========================================
Files 12 12
Lines 2791 2851 +60
===========================================
+ Hits 2553 2609 +56
- Misses 238 242 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
elbeejay
commented
Jul 23, 2026
Comment on lines
+117
to
+119
| self.qxn.flat[start_inlets] += start_counts * self.inlet_flow_dir[0] | ||
| self.qyn.flat[start_inlets] += start_counts * self.inlet_flow_dir[1] | ||
| self.qwn.flat[start_inlets] += start_counts * (self.Qp_water / self._dx / 2) |
Member
Author
There was a problem hiding this comment.
Looking for confirmation that this change in the index is correct; I'm not sure why we used to index for self.qxn with start_inlets and then start_indices for self.qwn...
elbeejay
marked this pull request as ready for review
July 23, 2026 01:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the ability to configure custom inlet coordinates and flow direction. It adds the
inlet_x,inlet_y, andinlet_flow_dirparameters, enabling inlets to be positioned at arbitrary locations with varying flow vectors instead of the default fixed behavior on the first grid row. Closes #241.