Skip to content

chore(skills): add Claude Code dev/review and parser skills - #15749

Merged
Maffooch merged 2 commits into
bugfixfrom
claude/add-dojo-review-parser-skills
Aug 20, 2026
Merged

chore(skills): add Claude Code dev/review and parser skills#15749
Maffooch merged 2 commits into
bugfixfrom
claude/add-dojo-review-parser-skills

Conversation

@Maffooch

@Maffooch Maffooch commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

[sc-14683]

Summary

Adds two repo-scoped Claude Code skills under .claude/skills/, plus a pointer to them from AGENTS.md, so the team's dev/review and parser-authoring workflows are shared and repeatable.

  • defectdojo-dev — the local dev/test loop: bring the Docker stack up on localhost:8080, reproduce a reported bug on the target branch before fixing it, write behavioral unit tests that fail without the fix, drive the UI with Playwright, and fetch an API token to exercise the REST API. Doubles as an inbound PR reviewer via concern lenses (scalability, performance, memory, DB resourcing, query design, security, DRF serializer exposure) plus a dedicated infra/Helm review checklist. Helper scripts: get-api-token.sh, run-tests.sh (wraps run-unittest.sh).
  • defectdojo-parser — authoring and reviewing scan-report parsers to the project's real conventions: factory contract, dedup registration in settings.dist.py and its impact on existing customer data (recomputing hash_code / the close-reopen loop), defusedxml/utf-8/Endpoint.from_uri rules, the 0/1/many test set with attribute-level assertions, sample-file sanitization + size discipline, and the unittests/test_parsers.py meta-test. Helper: new-parser-checklist.sh mirrors the meta-test locally.

Notes

  • .gitignore un-ignores .claude/skills/ using the same negation pattern already present for !.claude/hooks/ (the file documents this pattern). Personal config (settings.local.json, MEMORY.md, CLAUDE.md) stays ignored.
  • Documentation/tooling only — no application code, parser, migration, or test-suite changes. The skill content is grounded in the existing contributor docs (docs/content/get_started/contributing/how-to-write-a-parser.md), run-unittest.sh, dojo/tools/factory.py, and dojo/settings/settings.dist.py.
  • Content was validated by using the skills to review 10 open PRs and folding the gaps back in (infra/Helm CI checks, DRF exclude=/write-only exposure, dedup-impact-on-existing-data, loop-local parser state, severity-default nuance).

🤖 Generated with Claude Code

Add two repo-scoped Claude Code skills under .claude/skills/, plus a
pointer to them from AGENTS.md:

- defectdojo-dev: the local dev/test loop (bring the Docker stack up on
  localhost:8080, reproduce a bug on the target branch before fixing,
  write behavioral unit tests, drive the UI via Playwright, fetch an API
  token) that doubles as an inbound PR reviewer with concern lenses
  (scalability, performance, memory, DB resourcing, query design,
  security, DRF serializer exposure) and an infra/Helm review checklist.
  Helpers: get-api-token.sh, run-tests.sh.
- defectdojo-parser: authoring and reviewing scan-report parsers to the
  project's conventions (factory contract, dedup registration and its
  impact on existing data, defusedxml/utf-8/Endpoint.from_uri, the
  0/1/many test set, sample-file sanitization/size, and the
  unittests/test_parsers.py meta-test). Helper: new-parser-checklist.sh.

Un-ignore .claude/skills/ in .gitignore (same negation pattern already
used for .claude/hooks/) so the skills are shared in the repo.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@Maffooch
Maffooch requested a review from blakeaowens as a code owner August 20, 2026 15:02
@Maffooch Maffooch added this to the 3.2.300 milestone Aug 20, 2026
Convert the `A && B || C` check chains to explicit if/then/else (SC2015)
via check_path/check_grep helpers, and guard the `cd "$REPO_ROOT"`
(SC2164). Behavior is unchanged.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@Maffooch
Maffooch added this pull request to the merge queue Aug 20, 2026
Merged via the queue into bugfix with commit 19f94e3 Aug 20, 2026
49 checks passed
@Maffooch
Maffooch deleted the claude/add-dojo-review-parser-skills branch August 20, 2026 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants