Fix CorpusCallosum NumPy 2.5 compatibility#842
Open
karl-koschutnig wants to merge 3 commits into
Open
Conversation
ClePol
self-requested a review
July 9, 2026 11:54
Member
|
Behaviour might have changed in numpy 2.5, we used 2.4.4 in our last release and testing. |
m-reuter
changed the title
Member
|
please remove both tests (one is for bids anyway and not related to this PR, the others test mainly the shape equivalence and do not really help much). Also not sure about the _load_module, why that is needed. |
The BIDS passthrough test is unrelated to this fix, and the numpy compat test mainly asserted output shapes without exercising the underlying cross-product behavior, so it added little value. This also removes the only usage of _load_module, which loaded the CorpusCallosum modules by file path since they aren't installed as an importable package. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This separates the CorpusCallosum NumPy 2 compatibility fix from the BIDS PR.
Changes: