Upgrade vue-plotly to Vue3 + Vite + TS#53
Open
aurium wants to merge 16 commits into
Open
Conversation
|
Looks like the repo owner is inactive. Could this become a new standalone package? |
Author
I'm afraid you are right. I try to talk with David on LinkedIn without success. :-(
It is ok to me. We can start a team to maintain it. For now, come with PRs and issues to @aurium/vue-plotly We can move this repo to a new group be "less personal". |
Author
|
@Path-A I believe is that what you want: https://www.npmjs.com/package/@aurium/vue-plotly |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to make a real upgrade, not only a simple translation. So you'll find a lot of changes, but respecting your original concept.
Vue,@vueuse/coreandPlotly.js) to the bundle, letting it smaller and enabling users to upgrade these libs to take advantage of improvements and bug fixes.ResizeObserverfromvueuseto be responsive.Jesttest runner was replaced byVitestfor a better integration. (And it's really nice!)Plotly.jsinstance methods are extracted from its source and exposed by the component instance, with arg types, but the first.Plotly.jsmethods and listen for its events.(did I miss something?)