fix: install HTTP dependencies in Dockerfile for Kubernetes deployment - #34
Merged
Conversation
The deployment uses HTTP transport (MCP_TRANSPORT=http), which requires fastapi and uvicorn. These are defined as optional dependencies in pyproject.toml under the 'http' extra. Install with -e '.[http]' to include these dependencies in the Docker image. Fixes error: HTTP support requires 'uvicorn' and 'fastapi'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The high-command-mcp pods fail to start with the following error:
The deployment is configured to use HTTP transport (
MCP_TRANSPORT=http), which requiresfastapianduvicornpackages. However, the Dockerfile installs only the base dependencies without the[http]extra.Solution
Update the Dockerfile to install with the
[http]extra using-e ".[http]"to includefastapianduvicornin the Docker image.Changes
Dockerfileto install dependencies with-e ".[http]"instead of-e .fastapianduvicornpackages required for HTTP transportTesting
After rebuilding the image with this fix, the pods should start successfully when using HTTP transport mode.
Related
This fix complements the LOG_LEVEL case sensitivity fix that was already merged to main.