Defer node popover data fetches to open-time#2299
Merged
shangyian merged 1 commit intoJul 5, 2026
Merged
Conversation
ClientCodePopover (clientCode) and AddMaterializationPopover (materializationInfo) fetched on mount but only use the data inside the closed-by-default popover. Fetch on first open instead — removes ~6-8 redundant /new_node calls per node-page load (LCP 984->908ms) and a materializationInfo call per materialization-tab load. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
✅ Deploy Preview for thriving-cassata-78ae72 canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ClientCodePopover(for client code) andAddMaterializationPopoverfetched on mount but only use the data inside the closed-by-default popover. Fetch on first open instead to remove ~6-8 redundant server calls per node-page load and a materializationInfo call per materialization-tab load.Test Plan
make checkpassesmake testshows 100% unit test coverageDeployment Plan