Speed up namespace landing data loading#2297
Merged
Merged
Conversation
✅ Deploy Preview for thriving-cassata-78ae72 canceled.
|
f88abab to
54de945
Compare
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
54de945 to
fab9331
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A batch of independent optimizations to how the namespace landing page (
NamespacePage) fetches and renders its data.DJService.jsusers()dropswith_activity: The landing page and owner/edited-by dropdowns only use usernames, butwith_activity=truemade the endpoint join the entire history table.listNamespacesWithGitcaching: the namespace list is cached for 60s with aninvalidateNamespacesCache()escape hatch, so re-entering namespace pages doesn't refetch it every mount.nodeTypeCountsuses the new genericnodeCounts(groupBy: TYPE)query (one grouped scan) instead of 6 aliased per-type counts.NamespacePage/index.jsxgitConfigLoaded: for git-root namespaces the table used to fetch a provisional namespace, then refetch after the redirect to the default branch. Waiting for git config resolves that duplicate.CompactSelect.jsxAdd a windowed menu list (cap rendered options at 100) so large lists like the full user list don't make the dropdown super slow and unusable.
Test Plan
make checkpassesmake testshows 100% unit test coverageDeployment Plan