Add grouped nodeTypeCounts query; use COUNT(*) for totalCount#2296
Merged
Conversation
✅ Deploy Preview for thriving-cassata-78ae72 canceled.
|
5634ebd to
a6b9369
Compare
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
a6b9369 to
7483264
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The namespace landing page shows per-type filter pills ("Metric (342)", "Source (…)" etc). Today the UI populates them by firing one
findNodesPaginated(nodeTypes:[X], limit:1){ totalCount }per node type, which results in 5 separate count scans per page load (aliased into a single request, but still N scans server-side).This PR adds a generic server-side primitive to do it in one grouped scan, plus a small fix to the count query that backs every paginated totalCount.
New generic
nodeCountsqueryThis runs the existing filter builder with
GROUP BY <column>and returns{value: count}in one query. We deliberately kept this as a separate field, not folded intofindNodesPaginatedsince counting and pagination are different concerns.NodeGroupBystarts atTYPE, but addingSTATUS/MODElater is just an enum value + a column mapping.COUNT(*)instead ofCOUNT(DISTINCT id)fortotalCountNode.count_by(which backs every paginatedtotalCount) usedCOUNT(DISTINCT Node.id). However,COUNT(*)is exactly equivalent and skips the sort/hashDISTINCTforces. This change yields identical results, and it stops degrading with table size.Test Plan
make checkpassesmake testshows 100% unit test coverageDeployment Plan