Skip to content

chore(config): migrate OTTL transform to typed configuration - #2263

Open
webern wants to merge 1 commit into
m/confra-ofiltfrom
m/confra-otran
Open

chore(config): migrate OTTL transform to typed configuration#2263
webern wants to merge 1 commit into
m/confra-ofiltfrom
m/confra-otran

Conversation

@webern

@webern webern commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Summary

Migrate the OTTL span transform processor to the typed traces configuration. The processor now receives typed error-mode and transform-statement values, and its raw configuration adapter is removed.

Change Type

  • Non-functional (chore, refactoring, docs)

How did you test this PR?

  • make fmt
  • make check-docs
  • make check-clippy
  • make check-all
  • OTTL transform tests: 24 passed
  • cargo check -p agent-data-plane --tests

References

@pr-commenter

pr-commenter Bot commented Aug 5, 2026

Copy link
Copy Markdown

Binary Size Analysis (Agent Data Plane)

Baseline: 9e89350 · Comparison: dfe72f6 · diff
Analysis Configuration: stripped binaries · Pass/Fail Threshold: +5%
Sizes: 41.29 MiB (baseline) vs 41.02 MiB (comparison)
Size Change: -277.56 KiB (-0.66%)

✅ Binary size difference within threshold

Changes by Module
Module File Size Symbols
core -91.05 KiB 1756
figment -69.51 KiB 130
agent_data_plane::dogstatsd_contexts::artifact +24.91 KiB 6
serde_json -22.70 KiB 105
agent_data_plane::internal::remote_agent -21.81 KiB 22
anon.00dc0c417efcf499d873e738a2ef5693.801.llvm.14553289462941144855 -17.80 KiB 1
anon.ea545d9afa2102b2964dffe1e979445c.601.llvm.4886155512539480419 +17.71 KiB 1
std -16.85 KiB 113
prost -13.67 KiB 18
axum -12.77 KiB 206
anon.ea545d9afa2102b2964dffe1e979445c.712.llvm.4886155512539480419 +12.37 KiB 1
anon.092847ed9b6717aa6384694a3b142e5e.648.llvm.10377473450214868273 -12.28 KiB 1
[sections] -10.78 KiB 8
anon.ea545d9afa2102b2964dffe1e979445c.145.llvm.4886155512539480419 +9.71 KiB 1
anon.00dc0c417efcf499d873e738a2ef5693.811.llvm.14553289462941144855 -9.62 KiB 1
anon.ea545d9afa2102b2964dffe1e979445c.598.llvm.4886155512539480419 +9.15 KiB 1
anon.00dc0c417efcf499d873e738a2ef5693.797.llvm.14553289462941144855 -9.07 KiB 1
anon.ea545d9afa2102b2964dffe1e979445c.29.llvm.4886155512539480419 +8.75 KiB 1
anon.ce02f291c5ec2bd69c57e481e9867203.8.llvm.6990228221669555109 -8.66 KiB 1
alloc +8.57 KiB 546
Detailed Symbol Changes
    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +667% +24.7Ki  +687% +24.7Ki    agent_data_plane::dogstatsd_contexts::artifact::for_each_record::hb214cb615a40f66d
  [NEW] +17.7Ki  [NEW]     +76    anon.ea545d9afa2102b2964dffe1e979445c.601.llvm.4886155512539480419
  [NEW] +15.6Ki  [NEW] +15.4Ki    _<core::future::poll_fn::PollFn<F> as core::future::future::Future>::poll::ha97d3fe01c901fc7
  [NEW] +14.2Ki  [NEW] +14.1Ki    agent_data_plane::state::metrics::rules::get_compat_remappings::ha735e7d255c9ac0c
 +11e2% +12.9Ki +14e2% +12.9Ki    _<agent_data_plane::internal::remote_agent::RemoteAgentImpl as datadog_protos::agent_include::datadog::remoteagent::flare::v1::flare_provider_server::FlareProvider>::get_flare_files::_{{closure}}::ha8a04fa805ff7c04
  [NEW] +12.4Ki  [NEW]     +81    anon.ea545d9afa2102b2964dffe1e979445c.712.llvm.4886155512539480419
  [NEW] +9.71Ki  [NEW]     +79    anon.ea545d9afa2102b2964dffe1e979445c.145.llvm.4886155512539480419
  [NEW] +9.15Ki  [NEW]     +91    anon.ea545d9afa2102b2964dffe1e979445c.598.llvm.4886155512539480419
   +58% +8.76Ki   +58% +8.76Ki    agent_data_plane::state::metrics::rules::get_datadog_agent_remappings::h3bca9f6cd9d0a449
  [NEW] +8.75Ki  [NEW]     +81    anon.ea545d9afa2102b2964dffe1e979445c.29.llvm.4886155512539480419
  [DEL] -9.07Ki  [DEL]     -91    anon.00dc0c417efcf499d873e738a2ef5693.797.llvm.14553289462941144855
  [DEL] -9.62Ki  [DEL]     -79    anon.00dc0c417efcf499d873e738a2ef5693.811.llvm.14553289462941144855
  [DEL] -11.9Ki  [DEL] -11.8Ki    _<serde_json::de::StreamDeserializer<R,T> as core::iter::traits::iterator::Iterator>::next::h7097933b786ef05c
  [DEL] -12.3Ki  [DEL]     -81    anon.092847ed9b6717aa6384694a3b142e5e.648.llvm.10377473450214868273
  [DEL] -13.1Ki  [DEL] -13.0Ki    _<serde_json::de::StreamDeserializer<R,T> as core::iter::traits::iterator::Iterator>::next::h3c3ac6c22dc9e28d
  -1.2% -13.7Ki  -1.2% -13.7Ki    [section .gcc_except_table]
  [DEL] -15.2Ki  [DEL] -15.1Ki    agent_data_plane::state::metrics::rules::compat::get_compat_remappings::h21d415ffcc41c120
 -91.9% -16.4Ki -93.2% -16.4Ki    _<agent_data_plane::internal::remote_agent::RemoteAgentEventReporter as saluki_core::runtime::supervisor::Supervisable>::initialize::_{{closure}}::_{{closure}}::hc726395b4ae2250d
  [DEL] -17.2Ki  [DEL] -17.1Ki    agent_data_plane::internal::remote_agent::RemoteAgentImpl::session_id_middleware::_{{closure}}::h892c483d47a44569
  [DEL] -17.8Ki  [DEL]     -76    anon.00dc0c417efcf499d873e738a2ef5693.801.llvm.14553289462941144855
  -2.7%  -275Ki  -3.1%  -260Ki    [9757 Others]
  -0.7%  -277Ki  -0.8%  -272Ki    TOTAL

@pr-commenter

pr-commenter Bot commented Aug 5, 2026

Copy link
Copy Markdown

Regression Detector (Agent Data Plane)

Run ID: e701d43f-0d87-402d-8497-f3e6bdcf8727
Baseline: 9e893501 · Comparison: dfe72f69 · diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment (5)

Experiments configured erratic: true are tagged (ignored) and skipped when determining which experiments regressed or improved. Experiments which are detected as erratic at runtime are tagged (erratic) to flag that the run's sample dispersion was high, but their regression / improvement signal still counts.

experiment goal Δ mean % links
quality_gates_rss_dsd_ultraheavy memory ⚪ -0.06 metrics profiles logs
quality_gates_rss_dsd_low memory ⚪ -0.30 metrics profiles logs
quality_gates_rss_dsd_heavy memory ⚪ -0.48 metrics profiles logs
quality_gates_rss_dsd_medium memory ⚪ -0.50 metrics profiles logs
quality_gates_rss_idle memory ⚪ -0.51 metrics profiles logs
Bounds Checks: ✅ Passed (5)
experiment check replicates observed links
quality_gates_rss_dsd_heavy memory_usage 10/10 ✅ 139 MiB ≤ 145 MiB metrics profiles logs
quality_gates_rss_dsd_low memory_usage 10/10 ✅ 49.3 MiB ≤ 50 MiB metrics profiles logs
quality_gates_rss_dsd_medium memory_usage 10/10 ✅ 77.4 MiB ≤ 80 MiB metrics profiles logs
quality_gates_rss_dsd_ultraheavy memory_usage 10/10 ✅ 202 MiB ≤ 205 MiB metrics profiles logs
quality_gates_rss_idle memory_usage 10/10 ✅ 31.6 MiB ≤ 40 MiB metrics profiles logs
Explanation

A change is flagged as a regression when |Δ mean %| > 5.00% in the regressing direction for its optimization goal AND SMP marks the experiment as a regression (is_regression: true). Improvements use the matching criteria for the improving direction. Experiments configured erratic: true (tagged (ignored)) are skipped outright; experiments detected as erratic at runtime (tagged (erratic)) still count, since that flag describes sample dispersion rather than directional certainty. The Δ mean % cell is colored accordingly: 🟢 = improvement, 🔴 = regression, ⚪ = neutral. Reduction in CPU or memory is an improvement; reduction in ingress throughput is a regression.

@webern
webern force-pushed the m/confra-ofilt branch 2 times, most recently from 055b852 to 1005c62 Compare August 6, 2026 10:10
@webern
webern marked this pull request as ready for review August 6, 2026 10:18
@webern
webern requested a review from a team as a code owner August 6, 2026 10:18

@datadog-prod-us1-5 datadog-prod-us1-5 Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: PASS

More details

The migration consistently routes OTTL transform settings through the typed traces configuration, whose loader tests cover defaults, valid modes, invalid modes, unknown fields, file translation, and environment transport. No diff-only behavioral regression was found; focused Rust execution could not start because the sandbox could not fetch the pinned git dependency.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Datadog Autotest · Commit 0cb1e76 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest

@webern
webern force-pushed the m/confra-ofilt branch 2 times, most recently from fedf507 to dad25ce Compare August 6, 2026 12:31
@webern
webern force-pushed the m/confra-otran branch 2 times, most recently from d8f4844 to ef23127 Compare August 6, 2026 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant