fix: drop no-op install script that triggers Yarn build warning#363
Merged
Conversation
Yarn Berry (Plug'n'Play) prints "YN0007: @datadog/pprof must be built" for any dependency that declares an install/preinstall/postinstall script, even the no-op "exit 0". The package ships prebuilt binaries and excludes binding.gyp from the published tarball, so a consumer has nothing to build; the script only suppressed npm's implicit node-gyp rebuild in the dev tree, which CI and the prepare script do explicitly. Removing it stops the spurious warning for Yarn Berry consumers. Refs: DataDog/dd-trace-js#5432
|
Overall package sizeSelf size: 2.19 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | pprof-format | 2.2.2 | 500.53 kB | 500.53 kB | | source-map | 0.7.6 | 185.63 kB | 185.63 kB | | node-gyp-build | 4.8.4 | 13.86 kB | 13.86 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
szegedi
approved these changes
Jun 29, 2026
|
@BridgeAR this looks good to me – any particular reason it's still in draft? |
BridgeAR
requested review from
IlyasShabi,
nsavoire and
r1viollet
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Yarn Berry (Plug'n'Play) prints
YN0007: @datadog/pprof must be builtfor any dependency that declares aninstall/preinstall/postinstallscript, including the no-op"install": "exit 0". The package ships prebuilt binaries and excludesbinding.gypfrom the published tarball, so a consumer has nothing to build. The script only suppressed npm's implicitnode-gyp rebuildin the dev tree; CI and thepreparescript build explicitly.Dropping it stops the spurious warning for downstream Yarn Berry users, e.g. dd-trace on Vercel/Next.js.
A regression test (
ts/test/test-no-build-scripts.ts) asserts the manifest declares no build lifecycle scripts.Note (out of scope)
package.jsonhas apostinstallkey at the top level (outsidescripts; thenan/Node-24 sed fix). npm and Yarn ignore it there, so it does not trigger YN0007, but it also means that fix never runs. Left untouched here; worth a separate look.Test plan
yarn add @datadog/pprofunder Yarn Berry no longer prints YN0007Refs: DataDog/dd-trace-js#5432