refactor(statsd)!: make client clonable#2222
Open
VianneyRuhlmann wants to merge 1 commit into
Open
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
Clippy Allow Annotation ReportComparing clippy allow annotations between branches:
Summary by Rule
Annotation Counts by File
Annotation Stats by Crate
About This ReportThis report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality. |
Contributor
📚 Documentation Check Results📦
|
Contributor
🔒 Cargo Deny Results📦
|
Contributor
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: 30d94f8 | Docs | Datadog PR Page | Give us feedback! |
VianneyRuhlmann
force-pushed
the
vianney/statsd-client-refactor
branch
from
158eed0 to
597364e
Compare
BenchmarksComparisonBenchmark execution time: 2026-07-10 14:22:24 Comparing candidate commit 30d94f8 in PR branch Found 2 performance improvements and 0 performance regressions! Performance is the same for 22 metrics, 0 unstable metrics.
|
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | 30d94f8 | 1783692681 | vianney/statsd-client-refactor |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| trace_buffer/1_senders/10us_delay | execution_time | 56.324ms | 56.576ms ± 0.144ms | 56.548ms ± 0.074ms | 56.639ms | 56.821ms | 57.012ms | 57.353ms | 1.42% | 1.403 | 4.041 | 0.25% | 0.010ms | 1 | 200 |
| trace_buffer/1_senders/10us_delay | throughput | 15692.283op/s | 15908.048op/s ± 40.484op/s | 15915.551op/s ± 20.800op/s | 15935.857op/s | 15959.930op/s | 15970.641op/s | 15979.089op/s | 0.40% | -1.372 | 3.872 | 0.25% | 2.863op/s | 1 | 200 |
| trace_buffer/1_senders/1us_delay | execution_time | 50.025ms | 50.083ms ± 0.034ms | 50.081ms ± 0.012ms | 50.090ms | 50.150ms | 50.199ms | 50.210ms | 0.26% | 1.252 | 2.536 | 0.07% | 0.002ms | 1 | 200 |
| trace_buffer/1_senders/1us_delay | throughput | 17924.723op/s | 17970.246op/s ± 12.346op/s | 17970.935op/s ± 4.126op/s | 17976.264op/s | 17988.953op/s | 17990.272op/s | 17991.156op/s | 0.11% | -1.246 | 2.520 | 0.07% | 0.873op/s | 1 | 200 |
| trace_buffer/1_senders/no_delay | execution_time | 331.221µs | 342.410µs ± 5.038µs | 342.098µs ± 1.912µs | 344.023µs | 347.752µs | 354.139µs | 392.657µs | 14.78% | 5.062 | 48.217 | 1.47% | 0.356µs | 1 | 200 |
| trace_buffer/1_senders/no_delay | throughput | 2292076.953op/s | 2628953.887op/s ± 36257.313op/s | 2630823.874op/s ± 14707.459op/s | 2644876.402op/s | 2672401.330op/s | 2697644.312op/s | 2717222.255op/s | 3.28% | -4.078 | 36.203 | 1.38% | 2563.779op/s | 1 | 200 |
| trace_buffer/2_senders/10us_delay | execution_time | 56.738ms | 57.097ms ± 0.173ms | 57.086ms ± 0.122ms | 57.217ms | 57.390ms | 57.492ms | 57.711ms | 1.10% | 0.387 | 0.155 | 0.30% | 0.012ms | 1 | 200 |
| trace_buffer/2_senders/10us_delay | throughput | 31189.639op/s | 31525.762op/s ± 95.284op/s | 31531.241op/s ± 67.287op/s | 31594.218op/s | 31673.349op/s | 31717.936op/s | 31724.782op/s | 0.61% | -0.369 | 0.125 | 0.30% | 6.738op/s | 1 | 200 |
| trace_buffer/2_senders/1us_delay | execution_time | 50.036ms | 50.112ms ± 0.041ms | 50.102ms ± 0.020ms | 50.126ms | 50.201ms | 50.246ms | 50.276ms | 0.35% | 1.547 | 2.598 | 0.08% | 0.003ms | 1 | 200 |
| trace_buffer/2_senders/1us_delay | throughput | 35802.350op/s | 35919.711op/s ± 29.672op/s | 35926.758op/s ± 14.603op/s | 35940.894op/s | 35950.358op/s | 35953.857op/s | 35974.335op/s | 0.13% | -1.541 | 2.576 | 0.08% | 2.098op/s | 1 | 200 |
| trace_buffer/2_senders/no_delay | execution_time | 844.483µs | 909.888µs ± 19.021µs | 910.582µs ± 9.212µs | 919.820µs | 933.048µs | 953.321µs | 1029.411µs | 13.05% | 0.992 | 8.055 | 2.09% | 1.345µs | 1 | 200 |
| trace_buffer/2_senders/no_delay | throughput | 1748573.011op/s | 1979111.275op/s ± 40752.793op/s | 1976757.908op/s ± 20045.844op/s | 1996562.488op/s | 2049956.763op/s | 2074289.718op/s | 2131482.610op/s | 7.83% | -0.484 | 5.647 | 2.05% | 2881.658op/s | 1 | 200 |
| trace_buffer/4_senders/10us_delay | execution_time | 57.114ms | 57.396ms ± 0.118ms | 57.394ms ± 0.083ms | 57.477ms | 57.580ms | 57.631ms | 57.797ms | 0.70% | 0.220 | 0.301 | 0.20% | 0.008ms | 1 | 200 |
| trace_buffer/4_senders/10us_delay | throughput | 62287.282op/s | 62722.448op/s ± 128.393op/s | 62723.944op/s ± 90.650op/s | 62813.315op/s | 62928.306op/s | 62990.922op/s | 63031.309op/s | 0.49% | -0.206 | 0.283 | 0.20% | 9.079op/s | 1 | 200 |
| trace_buffer/4_senders/1us_delay | execution_time | 50.066ms | 50.166ms ± 0.040ms | 50.160ms ± 0.019ms | 50.178ms | 50.252ms | 50.296ms | 50.394ms | 0.47% | 1.903 | 6.294 | 0.08% | 0.003ms | 1 | 200 |
| trace_buffer/4_senders/1us_delay | throughput | 71436.743op/s | 71761.430op/s ± 56.697op/s | 71770.932op/s ± 26.628op/s | 71797.037op/s | 71823.646op/s | 71836.563op/s | 71905.068op/s | 0.19% | -1.892 | 6.228 | 0.08% | 4.009op/s | 1 | 200 |
| trace_buffer/4_senders/no_delay | execution_time | 2.085ms | 2.285ms ± 0.082ms | 2.284ms ± 0.054ms | 2.338ms | 2.416ms | 2.502ms | 2.521ms | 10.36% | 0.142 | -0.083 | 3.59% | 0.006ms | 1 | 200 |
| trace_buffer/4_senders/no_delay | throughput | 1428173.155op/s | 1577246.843op/s ± 56641.869op/s | 1576156.185op/s ± 36113.964op/s | 1611573.479op/s | 1676682.841op/s | 1691924.121op/s | 1726458.583op/s | 9.54% | 0.059 | -0.153 | 3.58% | 4005.185op/s | 1 | 200 |
| trace_buffer/8_senders/10us_delay | execution_time | 57.560ms | 57.930ms ± 0.225ms | 57.845ms ± 0.119ms | 58.073ms | 58.359ms | 58.492ms | 58.559ms | 1.23% | 0.880 | -0.162 | 0.39% | 0.016ms | 1 | 200 |
| trace_buffer/8_senders/10us_delay | throughput | 122953.789op/s | 124290.000op/s ± 480.181op/s | 124470.810op/s ± 256.204op/s | 124664.026op/s | 124836.740op/s | 124935.500op/s | 125086.438op/s | 0.49% | -0.868 | -0.189 | 0.39% | 33.954op/s | 1 | 200 |
| trace_buffer/8_senders/1us_delay | execution_time | 50.210ms | 50.291ms ± 0.055ms | 50.276ms ± 0.027ms | 50.319ms | 50.371ms | 50.488ms | 50.578ms | 0.60% | 1.795 | 5.407 | 0.11% | 0.004ms | 1 | 200 |
| trace_buffer/8_senders/1us_delay | throughput | 142354.721op/s | 143168.355op/s ± 156.214op/s | 143210.156op/s ± 76.046op/s | 143265.527op/s | 143364.432op/s | 143382.201op/s | 143396.953op/s | 0.13% | -1.782 | 5.329 | 0.11% | 11.046op/s | 1 | 200 |
| trace_buffer/8_senders/no_delay | execution_time | 6.127ms | 6.480ms ± 0.073ms | 6.480ms ± 0.044ms | 6.523ms | 6.598ms | 6.642ms | 6.651ms | 2.63% | -0.418 | 1.953 | 1.12% | 0.005ms | 1 | 200 |
| trace_buffer/8_senders/no_delay | throughput | 1082534.104op/s | 1111270.721op/s ± 12561.005op/s | 1111041.185op/s ± 7504.964op/s | 1118681.011op/s | 1132681.415op/s | 1138590.047op/s | 1175035.777op/s | 5.76% | 0.552 | 2.477 | 1.13% | 888.197op/s | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| trace_buffer/1_senders/10us_delay | execution_time | [56.555ms; 56.596ms] or [-0.035%; +0.035%] | None | None | None |
| trace_buffer/1_senders/10us_delay | throughput | [15902.437op/s; 15913.659op/s] or [-0.035%; +0.035%] | None | None | None |
| trace_buffer/1_senders/1us_delay | execution_time | [50.078ms; 50.088ms] or [-0.010%; +0.010%] | None | None | None |
| trace_buffer/1_senders/1us_delay | throughput | [17968.535op/s; 17971.957op/s] or [-0.010%; +0.010%] | None | None | None |
| trace_buffer/1_senders/no_delay | execution_time | [341.712µs; 343.109µs] or [-0.204%; +0.204%] | None | None | None |
| trace_buffer/1_senders/no_delay | throughput | [2623928.972op/s; 2633978.802op/s] or [-0.191%; +0.191%] | None | None | None |
| trace_buffer/2_senders/10us_delay | execution_time | [57.073ms; 57.121ms] or [-0.042%; +0.042%] | None | None | None |
| trace_buffer/2_senders/10us_delay | throughput | [31512.556op/s; 31538.967op/s] or [-0.042%; +0.042%] | None | None | None |
| trace_buffer/2_senders/1us_delay | execution_time | [50.106ms; 50.118ms] or [-0.011%; +0.011%] | None | None | None |
| trace_buffer/2_senders/1us_delay | throughput | [35915.599op/s; 35923.824op/s] or [-0.011%; +0.011%] | None | None | None |
| trace_buffer/2_senders/no_delay | execution_time | [907.252µs; 912.524µs] or [-0.290%; +0.290%] | None | None | None |
| trace_buffer/2_senders/no_delay | throughput | [1973463.330op/s; 1984759.221op/s] or [-0.285%; +0.285%] | None | None | None |
| trace_buffer/4_senders/10us_delay | execution_time | [57.380ms; 57.412ms] or [-0.028%; +0.028%] | None | None | None |
| trace_buffer/4_senders/10us_delay | throughput | [62704.654op/s; 62740.242op/s] or [-0.028%; +0.028%] | None | None | None |
| trace_buffer/4_senders/1us_delay | execution_time | [50.161ms; 50.172ms] or [-0.011%; +0.011%] | None | None | None |
| trace_buffer/4_senders/1us_delay | throughput | [71753.572op/s; 71769.287op/s] or [-0.011%; +0.011%] | None | None | None |
| trace_buffer/4_senders/no_delay | execution_time | [2.274ms; 2.297ms] or [-0.498%; +0.498%] | None | None | None |
| trace_buffer/4_senders/no_delay | throughput | [1569396.824op/s; 1585096.861op/s] or [-0.498%; +0.498%] | None | None | None |
| trace_buffer/8_senders/10us_delay | execution_time | [57.899ms; 57.961ms] or [-0.054%; +0.054%] | None | None | None |
| trace_buffer/8_senders/10us_delay | throughput | [124223.452op/s; 124356.549op/s] or [-0.054%; +0.054%] | None | None | None |
| trace_buffer/8_senders/1us_delay | execution_time | [50.283ms; 50.298ms] or [-0.015%; +0.015%] | None | None | None |
| trace_buffer/8_senders/1us_delay | throughput | [143146.705op/s; 143190.005op/s] or [-0.015%; +0.015%] | None | None | None |
| trace_buffer/8_senders/no_delay | execution_time | [6.470ms; 6.490ms] or [-0.156%; +0.156%] | None | None | None |
| trace_buffer/8_senders/no_delay | throughput | [1109529.886op/s; 1113011.555op/s] or [-0.157%; +0.157%] | None | None | None |
Group 1
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | 30d94f8 | 1783692681 | vianney/statsd-client-refactor |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| concentrator/add_spans_to_concentrator | execution_time | 8.450ms | 8.474ms ± 0.016ms | 8.470ms ± 0.010ms | 8.483ms | 8.508ms | 8.521ms | 8.529ms | 0.70% | 1.023 | 0.834 | 0.19% | 0.001ms | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| concentrator/add_spans_to_concentrator | execution_time | [8.471ms; 8.476ms] or [-0.027%; +0.027%] | None | None | None |
Group 2
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | 30d94f8 | 1783692681 | vianney/statsd-client-refactor |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| write only interface | execution_time | 1.056µs | 1.074µs ± 0.005µs | 1.075µs ± 0.003µs | 1.077µs | 1.080µs | 1.085µs | 1.088µs | 1.18% | -0.412 | 0.426 | 0.48% | 0.000µs | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| write only interface | execution_time | [1.073µs; 1.074µs] or [-0.067%; +0.067%] | None | None | None |
Group 3
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | 30d94f8 | 1783692681 | vianney/statsd-client-refactor |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| two way interface | execution_time | 15.310µs | 15.729µs ± 0.210µs | 15.699µs ± 0.105µs | 15.826µs | 16.165µs | 16.384µs | 16.483µs | 4.99% | 1.130 | 1.564 | 1.33% | 0.015µs | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| two way interface | execution_time | [15.700µs; 15.758µs] or [-0.185%; +0.185%] | None | None | None |
Baseline
Baseline benchmark details
Group 1
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | a41a0f4 | 1783685334 | main |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| trace_buffer/1_senders/10us_delay | execution_time | 56.289ms | 56.554ms ± 0.137ms | 56.526ms ± 0.063ms | 56.605ms | 56.799ms | 57.008ms | 57.273ms | 1.32% | 1.654 | 4.775 | 0.24% | 0.010ms | 1 | 200 |
| trace_buffer/1_senders/10us_delay | throughput | 15714.099op/s | 15914.075op/s ± 38.265op/s | 15921.895op/s ± 17.789op/s | 15936.307op/s | 15961.406op/s | 15977.820op/s | 15988.826op/s | 0.42% | -1.625 | 4.621 | 0.24% | 2.706op/s | 1 | 200 |
| trace_buffer/1_senders/1us_delay | execution_time | 49.979ms | 50.077ms ± 0.035ms | 50.080ms ± 0.013ms | 50.087ms | 50.140ms | 50.178ms | 50.270ms | 0.38% | 1.238 | 4.830 | 0.07% | 0.002ms | 1 | 200 |
| trace_buffer/1_senders/1us_delay | throughput | 17903.420op/s | 17972.382op/s ± 12.428op/s | 17971.108op/s ± 4.752op/s | 17979.499op/s | 17989.365op/s | 17990.388op/s | 18007.432op/s | 0.20% | -1.227 | 4.775 | 0.07% | 0.879op/s | 1 | 200 |
| trace_buffer/1_senders/no_delay | execution_time | 334.032µs | 340.966µs ± 3.994µs | 340.470µs ± 1.919µs | 342.316µs | 347.125µs | 354.051µs | 372.142µs | 9.30% | 3.024 | 18.287 | 1.17% | 0.282µs | 1 | 200 |
| trace_buffer/1_senders/no_delay | throughput | 2418433.674op/s | 2639904.712op/s ± 29933.615op/s | 2643404.228op/s ± 14902.943op/s | 2659265.979op/s | 2671072.563op/s | 2682244.056op/s | 2694350.569op/s | 1.93% | -2.666 | 14.764 | 1.13% | 2116.626op/s | 1 | 200 |
| trace_buffer/2_senders/10us_delay | execution_time | 56.701ms | 57.124ms ± 0.175ms | 57.103ms ± 0.114ms | 57.224ms | 57.423ms | 57.504ms | 57.563ms | 0.81% | 0.210 | -0.307 | 0.31% | 0.012ms | 1 | 200 |
| trace_buffer/2_senders/10us_delay | throughput | 31270.018op/s | 31510.599op/s ± 96.653op/s | 31522.051op/s ± 62.537op/s | 31571.533op/s | 31671.998op/s | 31711.210op/s | 31745.295op/s | 0.71% | -0.195 | -0.311 | 0.31% | 6.834op/s | 1 | 200 |
| trace_buffer/2_senders/1us_delay | execution_time | 50.065ms | 50.111ms ± 0.030ms | 50.108ms ± 0.016ms | 50.121ms | 50.170ms | 50.221ms | 50.225ms | 0.23% | 1.348 | 2.447 | 0.06% | 0.002ms | 1 | 200 |
| trace_buffer/2_senders/1us_delay | throughput | 35838.799op/s | 35920.533op/s ± 21.732op/s | 35922.088op/s ± 11.781op/s | 35935.533op/s | 35948.180op/s | 35951.276op/s | 35953.058op/s | 0.09% | -1.343 | 2.430 | 0.06% | 1.537op/s | 1 | 200 |
| trace_buffer/2_senders/no_delay | execution_time | 864.057µs | 914.040µs ± 17.520µs | 914.234µs ± 8.828µs | 923.070µs | 937.473µs | 950.707µs | 1028.718µs | 12.52% | 1.146 | 8.370 | 1.91% | 1.239µs | 1 | 200 |
| trace_buffer/2_senders/no_delay | throughput | 1749750.661op/s | 1969986.759op/s ± 37116.090op/s | 1968862.226op/s ± 18904.161op/s | 1987760.507op/s | 2027879.131op/s | 2062440.638op/s | 2083194.829op/s | 5.81% | -0.688 | 5.666 | 1.88% | 2624.504op/s | 1 | 200 |
| trace_buffer/4_senders/10us_delay | execution_time | 57.033ms | 57.423ms ± 0.165ms | 57.376ms ± 0.091ms | 57.527ms | 57.701ms | 57.890ms | 57.947ms | 0.99% | 0.662 | 0.242 | 0.29% | 0.012ms | 1 | 200 |
| trace_buffer/4_senders/10us_delay | throughput | 62126.193op/s | 62693.616op/s ± 180.312op/s | 62744.013op/s ± 99.751op/s | 62822.398op/s | 62926.660op/s | 63020.083op/s | 63121.248op/s | 0.60% | -0.647 | 0.216 | 0.29% | 12.750op/s | 1 | 200 |
| trace_buffer/4_senders/1us_delay | execution_time | 50.111ms | 50.165ms ± 0.034ms | 50.158ms ± 0.018ms | 50.179ms | 50.237ms | 50.271ms | 50.281ms | 0.25% | 1.261 | 1.523 | 0.07% | 0.002ms | 1 | 200 |
| trace_buffer/4_senders/1us_delay | throughput | 71597.832op/s | 71763.103op/s ± 48.283op/s | 71773.343op/s ± 25.446op/s | 71796.764op/s | 71819.071op/s | 71832.715op/s | 71840.435op/s | 0.09% | -1.257 | 1.512 | 0.07% | 3.414op/s | 1 | 200 |
| trace_buffer/4_senders/no_delay | execution_time | 2.183ms | 2.400ms ± 0.083ms | 2.406ms ± 0.061ms | 2.461ms | 2.514ms | 2.554ms | 2.578ms | 7.15% | -0.431 | -0.287 | 3.45% | 0.006ms | 1 | 200 |
| trace_buffer/4_senders/no_delay | throughput | 1396479.166op/s | 1501654.201op/s ± 52915.325op/s | 1496357.805op/s ± 37784.508op/s | 1537962.978op/s | 1600470.365op/s | 1639917.181op/s | 1648730.507op/s | 10.18% | 0.593 | -0.064 | 3.51% | 3741.679op/s | 1 | 200 |
| trace_buffer/8_senders/10us_delay | execution_time | 57.655ms | 57.944ms ± 0.208ms | 57.858ms ± 0.115ms | 58.102ms | 58.336ms | 58.434ms | 58.516ms | 1.14% | 0.763 | -0.474 | 0.36% | 0.015ms | 1 | 200 |
| trace_buffer/8_senders/10us_delay | throughput | 123044.031op/s | 124259.580op/s ± 444.066op/s | 124441.739op/s ± 246.794op/s | 124569.174op/s | 124800.762op/s | 124868.423op/s | 124881.471op/s | 0.35% | -0.753 | -0.494 | 0.36% | 31.400op/s | 1 | 200 |
| trace_buffer/8_senders/1us_delay | execution_time | 50.207ms | 50.282ms ± 0.054ms | 50.270ms ± 0.025ms | 50.299ms | 50.373ms | 50.492ms | 50.607ms | 0.67% | 2.305 | 8.434 | 0.11% | 0.004ms | 1 | 200 |
| trace_buffer/8_senders/1us_delay | throughput | 142272.147op/s | 143193.098op/s ± 153.202op/s | 143227.188op/s ± 71.361op/s | 143284.553op/s | 143364.738op/s | 143397.957op/s | 143407.686op/s | 0.13% | -2.289 | 8.317 | 0.11% | 10.833op/s | 1 | 200 |
| trace_buffer/8_senders/no_delay | execution_time | 6.134ms | 6.550ms ± 0.109ms | 6.564ms ± 0.063ms | 6.624ms | 6.702ms | 6.741ms | 6.745ms | 2.76% | -0.974 | 1.576 | 1.66% | 0.008ms | 1 | 200 |
| trace_buffer/8_senders/no_delay | throughput | 1067394.129op/s | 1099561.666op/s ± 18590.383op/s | 1096875.409op/s ± 10698.871op/s | 1108680.668op/s | 1132969.652op/s | 1157773.548op/s | 1173760.391op/s | 7.01% | 1.110 | 2.032 | 1.69% | 1314.539op/s | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| trace_buffer/1_senders/10us_delay | execution_time | [56.535ms; 56.573ms] or [-0.033%; +0.033%] | None | None | None |
| trace_buffer/1_senders/10us_delay | throughput | [15908.771op/s; 15919.378op/s] or [-0.033%; +0.033%] | None | None | None |
| trace_buffer/1_senders/1us_delay | execution_time | [50.072ms; 50.082ms] or [-0.010%; +0.010%] | None | None | None |
| trace_buffer/1_senders/1us_delay | throughput | [17970.659op/s; 17974.104op/s] or [-0.010%; +0.010%] | None | None | None |
| trace_buffer/1_senders/no_delay | execution_time | [340.413µs; 341.520µs] or [-0.162%; +0.162%] | None | None | None |
| trace_buffer/1_senders/no_delay | throughput | [2635756.201op/s; 2644053.224op/s] or [-0.157%; +0.157%] | None | None | None |
| trace_buffer/2_senders/10us_delay | execution_time | [57.100ms; 57.148ms] or [-0.043%; +0.043%] | None | None | None |
| trace_buffer/2_senders/10us_delay | throughput | [31497.204op/s; 31523.994op/s] or [-0.043%; +0.043%] | None | None | None |
| trace_buffer/2_senders/1us_delay | execution_time | [50.106ms; 50.115ms] or [-0.008%; +0.008%] | None | None | None |
| trace_buffer/2_senders/1us_delay | throughput | [35917.522op/s; 35923.545op/s] or [-0.008%; +0.008%] | None | None | None |
| trace_buffer/2_senders/no_delay | execution_time | [911.612µs; 916.468µs] or [-0.266%; +0.266%] | None | None | None |
| trace_buffer/2_senders/no_delay | throughput | [1964842.826op/s; 1975130.692op/s] or [-0.261%; +0.261%] | None | None | None |
| trace_buffer/4_senders/10us_delay | execution_time | [57.400ms; 57.446ms] or [-0.040%; +0.040%] | None | None | None |
| trace_buffer/4_senders/10us_delay | throughput | [62668.626op/s; 62718.605op/s] or [-0.040%; +0.040%] | None | None | None |
| trace_buffer/4_senders/1us_delay | execution_time | [50.160ms; 50.170ms] or [-0.009%; +0.009%] | None | None | None |
| trace_buffer/4_senders/1us_delay | throughput | [71756.411op/s; 71769.794op/s] or [-0.009%; +0.009%] | None | None | None |
| trace_buffer/4_senders/no_delay | execution_time | [2.389ms; 2.412ms] or [-0.480%; +0.480%] | None | None | None |
| trace_buffer/4_senders/no_delay | throughput | [1494320.646op/s; 1508987.756op/s] or [-0.488%; +0.488%] | None | None | None |
| trace_buffer/8_senders/10us_delay | execution_time | [57.915ms; 57.973ms] or [-0.050%; +0.050%] | None | None | None |
| trace_buffer/8_senders/10us_delay | throughput | [124198.037op/s; 124321.123op/s] or [-0.050%; +0.050%] | None | None | None |
| trace_buffer/8_senders/1us_delay | execution_time | [50.274ms; 50.289ms] or [-0.015%; +0.015%] | None | None | None |
| trace_buffer/8_senders/1us_delay | throughput | [143171.866op/s; 143214.331op/s] or [-0.015%; +0.015%] | None | None | None |
| trace_buffer/8_senders/no_delay | execution_time | [6.535ms; 6.565ms] or [-0.230%; +0.230%] | None | None | None |
| trace_buffer/8_senders/no_delay | throughput | [1096985.218op/s; 1102138.114op/s] or [-0.234%; +0.234%] | None | None | None |
Group 1
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | a41a0f4 | 1783685334 | main |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| concentrator/add_spans_to_concentrator | execution_time | 8.445ms | 8.476ms ± 0.018ms | 8.472ms ± 0.012ms | 8.487ms | 8.507ms | 8.529ms | 8.548ms | 0.90% | 1.124 | 1.642 | 0.21% | 0.001ms | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| concentrator/add_spans_to_concentrator | execution_time | [8.474ms; 8.479ms] or [-0.030%; +0.030%] | None | None | None |
Group 2
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | a41a0f4 | 1783685334 | main |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| write only interface | execution_time | 1.067µs | 1.078µs ± 0.004µs | 1.079µs ± 0.001µs | 1.080µs | 1.083µs | 1.086µs | 1.089µs | 0.93% | -1.020 | 1.578 | 0.34% | 0.000µs | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| write only interface | execution_time | [1.078µs; 1.079µs] or [-0.047%; +0.047%] | None | None | None |
Group 3
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | a41a0f4 | 1783685334 | main |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| two way interface | execution_time | 15.610µs | 15.920µs ± 0.203µs | 15.863µs ± 0.084µs | 15.974µs | 16.271µs | 16.439µs | 17.219µs | 8.55% | 2.581 | 11.431 | 1.27% | 0.014µs | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| two way interface | execution_time | [15.892µs; 15.948µs] or [-0.177%; +0.177%] | None | None | None |
Contributor
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
VianneyRuhlmann
changed the title
VianneyRuhlmann
force-pushed
the
vianney/statsd-client-refactor
branch
from
597364e to
b905f96
Compare
VianneyRuhlmann
force-pushed
the
vianney/statsd-client-refactor
branch
from
b905f96 to
30d94f8
Compare
VianneyRuhlmann
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 30d94f86f0
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Comment on lines
+123
to
+127
| match self.inner.client.get() { | ||
| Some(client) => Ok(client), | ||
| None => { | ||
| let client = Self::create_client(&self.inner.endpoint)?; | ||
| Ok(self.inner.client.get_or_init(|| client)) |
There was a problem hiding this comment.
When the first metric is sent concurrently, every caller that observes None runs create_client before get_or_init; that construction does DNS/socket setup and creates a QueuingMetricSink worker, but all except the winner are immediately dropped. This regresses the old mutex-serialized initialization and can spawn many transient queue workers/socket binds during startup bursts, so the fallible construction should be protected by a single initialization path.
Useful? React with 👍 / 👎.
Aaalibaba42
reviewed
Jul 10, 2026
Aaalibaba42
left a comment
Aaalibaba42
left a comment
Contributor
There was a problem hiding this comment.
Mostly nits, I don't know dogstatsd enough to approve though, just looked at the code.
Comment on lines
+21
to
+34
| /// A dogstatsd-client that flushes stats to a given endpoint. | ||
| /// | ||
| /// This client can be cloned and shared between threads. | ||
| #[derive(Debug, Default, Clone)] | ||
| pub struct DogStatsDClient { | ||
| inner: Arc<InnerClient>, | ||
| } | ||
|
|
||
| /// Inner struct of [DogStatsDClient] to be wrapped in [Arc]. | ||
| #[derive(Debug, Default)] | ||
| struct InnerClient { | ||
| client: OnceLock<StatsdClient>, | ||
| endpoint: Endpoint, | ||
| } |
Contributor
There was a problem hiding this comment.
nit: I understand why it's more legible this way but I think I'd have preferred a struct DogStatsDClient(Arc<InnerClient>) or even struct DogStatsDClient(Arc<(OnceLock<StatsdClient>, Endpoint)>), I feel like this Inner struct is just for language reasons and not sementic
Contributor
Author
There was a problem hiding this comment.
I agree with struct DogStatsDClient(Arc<InnerClient>) but I'd rather have a proper struct to held Client fields rather than a tuple which is less readable in methods
Comment on lines
+123
to
+129
| match self.inner.client.get() { | ||
| Some(client) => Ok(client), | ||
| None => { | ||
| let client = Self::create_client(&self.inner.endpoint)?; | ||
| Ok(self.inner.client.get_or_init(|| client)) | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
nit: slightly more legible imho
Suggested change
| match self.inner.client.get() { | |
| Some(client) => Ok(client), | |
| None => { | |
| let client = Self::create_client(&self.inner.endpoint)?; | |
| Ok(self.inner.client.get_or_init(|| client)) | |
| } | |
| } | |
| if let Some(client) = self.inner.client.get() { | |
| return Ok(client); | |
| } | |
| let client = Self::create_client(&self.inner.endpoint)?; | |
| Ok(self.inner.client.get_or_init(|| client)) |
Comment on lines
+153
to
+163
| { | ||
| let mut tags_iter = tags.into_iter(); | ||
| let mut tag_opt = tags_iter.next(); | ||
| #[allow(clippy::unwrap_used)] | ||
| while tag_opt.is_some() { | ||
| builder = builder.with_tag_value(tag_opt.unwrap().as_ref()); | ||
| tag_opt = tags_iter.next(); | ||
| } | ||
| builder.try_send()?; | ||
| Ok(()) | ||
| } |
Contributor
There was a problem hiding this comment.
nit:
Suggested change
| { | |
| let mut tags_iter = tags.into_iter(); | |
| let mut tag_opt = tags_iter.next(); | |
| #[allow(clippy::unwrap_used)] | |
| while tag_opt.is_some() { | |
| builder = builder.with_tag_value(tag_opt.unwrap().as_ref()); | |
| tag_opt = tags_iter.next(); | |
| } | |
| builder.try_send()?; | |
| Ok(()) | |
| } | |
| { | |
| let mut tags_iter = tags.into_iter(); | |
| while let Some(tag) = tag_opt.next() { | |
| builder = builder.with_tag_value(tog.as_ref()); | |
| } | |
| builder.try_send()?; | |
| Ok(()) | |
| } |
or even just this since V is IntoIterator
Suggested change
| { | |
| let mut tags_iter = tags.into_iter(); | |
| let mut tag_opt = tags_iter.next(); | |
| #[allow(clippy::unwrap_used)] | |
| while tag_opt.is_some() { | |
| builder = builder.with_tag_value(tag_opt.unwrap().as_ref()); | |
| tag_opt = tags_iter.next(); | |
| } | |
| builder.try_send()?; | |
| Ok(()) | |
| } | |
| { | |
| for tag in tags { | |
| builder = builder.with_tag_value(tag.as_ref()); | |
| } | |
| builder.try_send()?; | |
| Ok(()) | |
| } |
Contributor
Author
There was a problem hiding this comment.
Good catch this code has some really weird designs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Refactor of the dogstatsd client crate.
Main changes are:
actionclientandclient/sinkClienttoDogStatDClientto avoid renames when importing in other cratesnew,create_clientanddo_sendto be method of theDogStatsDClientDogStatsDClientto use aOnceLockand make the client handle clonableMotivation
I've encountered several issues with the current design when sharing the client with the StatsExporter in #2159 and when adding the SharedRuntime backed client #2224 .
Additional Notes
Anything else we should know when reviewing?
How to test the change?
Describe here in detail how the change can be validated.