Skip to content

Fix C99 extensions compilation error with Clang #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xlamorlette-datadog merged 1 commit into from
Aug 20, 2026
Merged

Fix C99 extensions compilation error with Clang #358

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions src/datadog/otel_process_ctx.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,15 +14,17 @@
#define _GNU_SOURCE
#endif

#if defined(__GNUC__) && defined(__cplusplus) && __cplusplus < 202002L
#if defined(__GNUC__) && defined(__cplusplus)
// This file uses C99 compound literals with designated initializers
// throughout. They are standard in C (since C99) and in C++ (since C++20),
// but trigger -Wpedantic (older GCC) or -Wc++20-extensions (newer GCC) when
// compiled as C++17 or older. Silencing -Wpragmas first lets GCC versions
// that don't know -Wc++20-extensions accept the pragma silently.
// throughout. Designated initializers are standard in C++20; compound
// literals themselves never are. This triggers -Wpedantic (older GCC) or
// -Wc++20-extensions (newer GCC) under C++17 or older, and -Wc99-extensions
// (Clang) regardless of dialect. Silencing -Wpragmas first lets GCC
// versions that don't know -Wc++20-extensions accept the pragma silently.
#pragma GCC diagnostic ignored "-Wpragmas"
#pragma GCC diagnostic ignored "-Wpedantic"
#pragma GCC diagnostic ignored "-Wc++20-extensions"
#pragma GCC diagnostic ignored "-Wc99-extensions"
#endif

// Note: Things here are needed for NOOP. Things that are only for non-NOOP get added further below.
Expand Down
Loading