Skip to content

feat(tracing): add DD_TRACE_PROPAGATION_EXTRACT_FIRST - #356

Draft
MilanGarnier wants to merge 1 commit into
mainfrom
milan.garnier/propagation-extract-first
Draft

feat(tracing): add DD_TRACE_PROPAGATION_EXTRACT_FIRST#356
MilanGarnier wants to merge 1 commit into
mainfrom
milan.garnier/propagation-extract-first

Conversation

@MilanGarnier

Copy link
Copy Markdown
Contributor

Description

Adds C++ support for DD_TRACE_PROPAGATION_EXTRACT_FIRST.

Motivation

Allow extraction to stop after the first successfully extracted trace context, matching the shared tracer configuration.

Additional Notes

Priority: low

  • Generated supported-configurations.json with config-inversion.
  • Unit tests cover configuration precedence, heterogeneous W3C tracestate handling, and fallback after an unsuccessful extractor.

Jira ticket: N/A

@pr-commenter

pr-commenter Bot commented Aug 19, 2026

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-08-19 09:47:56

Comparing candidate commit 9f8c667 in PR branch milan.garnier/propagation-extract-first with baseline commit 765983d in branch main.

Found 2 performance improvements and 1 performance regressions! Performance is the same for 5 metrics, 0 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:BM_HexPadded_uint64/NoPadding

  • 🟥 execution_time [+1.566ns; +1.658ns] or [+2.989%; +3.164%]

scenario:BM_TraceID_ParseHex/128bit

  • 🟩 execution_time [-50.098ns; -50.003ns] or [-28.996%; -28.941%]

scenario:BM_TraceID_ParseHex/64bit

  • 🟩 execution_time [-22.506ns; -22.490ns] or [-24.525%; -24.507%]

@datadog-datadog-prod-us1-2

Copy link
Copy Markdown

🎯 Code Coverage (details)
Patch Coverage: 85.71%
Overall Coverage: 84.48% (+0.00%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 9f8c667 | Docs | View more details | Give us feedback!

@MilanGarnier MilanGarnier added the AI Generated Largely based on code generated by an AI or LLM. This label is the same across all dd-trace-* repos label Aug 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI Generated Largely based on code generated by an AI or LLM. This label is the same across all dd-trace-* repos

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant