feat(tracing): add OpenTelemetry tracestate sampling - #354
Conversation
BenchmarksBenchmark execution time: 2026-08-20 12:29:05 Comparing candidate commit 6eb3ba3 in PR branch Found 3 performance improvements and 2 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics.
|
This comment has been minimized.
This comment has been minimized.
0bbacfe to
e6c71eb
Compare
e6c71eb to
3c6394e
Compare
93fdd98 to
cb6e08f
Compare
xlamorlette-datadog
left a comment
There was a problem hiding this comment.
Mostly nit and opt comments.
| if (!decision.mechanism || !decision.configured_rate || | ||
| !decision.probability_sampled || | ||
| !is_probability_mechanism(*decision.mechanism) || | ||
| (*decision.probability_sampled && decision.priority <= 0)) { |
There was a problem hiding this comment.
nit: extract this last condition (*decision.probability_sampled && decision.priority <= 0) into a named variable
a9987e8 to
f69c256
Compare
f69c256 to
6eb3ba3
Compare
Summary
Adds W3C
tracestatesupport for OpenTelemetryotsampling state.otseparately from Datadog and other vendor state.rvandthvalues, and writes sampling values for eligible local probability decisions.Testing
cmake --build .build -j./.build/test/tests