implement base-engine items - #2
Draft
eyedine2 wants to merge 5 commits into
Draft
Conversation
eyedine2
marked this pull request as draft
August 2, 2026 08:20
Author
|
converting this to a draft because it needs more work. |
items of every type have a getdialoguetexts() function which allows you to override text in an item without reconstructing the use function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(both base-engine and mod items being loaded at the same time, the Bisicle overrides its default text.)
What this does:
This does completely override their use functions, which may be completely unnecessary. It's a rough addition for now.(fixed by putting the final dialogue text into its own function that can be overwritten)Note:
As I said, item use being overridden is not ideal. Items should support comments on their own and be able to change the dialogue text without going into the use function. Maybe a getUseComment function?(again, fixed)These were not rigorously tested, I do not know if they work in every situation. I am not a good coder, I may have missed some things. But overall I think it's a good step towards adding boilerplate items people may be wanting to use a lot.