feat(env): add .dailybot/env.json per-repo API key override

[xergioalex]

Summary

Introduce a new opt-in, gitignored .dailybot/env.json file that lets developers configure per-repo API keys + URLs for multiple environments (live, local, staging, ...) with one-command switching. When active, it overrides DAILYBOT_API_KEY, config.json, and the login Bearer session for the enclosing repo — enabling "logged into different orgs in different repos" without touching global state.

The motivating pain: today, switching between local dev orgs, staging, and production requires either exporting DAILYBOT_API_URL / DAILYBOT_APP_URL / DAILYBOT_API_KEY for every shell, or reconfiguring the global agents.json. env.json gives each repo its own credential context that follows the working directory.

Design

Schema

{
  "disabled": false,
  "active": "local org 1",
  "profiles": [
    { "name": "live", "api_key": "sk_live_xxx" },
    {
      "name": "local org 1",
      "api_key": "sk_local_xxx",
      "api_url": "http://localhost:8000",
      "app_url": "http://localhost:8090"
    },
    {
      "name": "staging",
      "api_key": "sk_staging_xxx",
      "api_url": "https://staging-api.example.com",
      "app_url": "https://staging-app.example.com"
    }
  ]
}

• active — top-level string (impossible to have two actives; empty/null/missing → file is inert).
• disabled: true — kill-switch that preserves active for quick re-enable (env off / env on).
• api_url / app_url per profile — optional; fall through to defaults when absent.
• snake_case across the board (consistent with credentials.json, agents.json, config.json).

CLI surface — new env command group

dailybot env add --name --key [--api-url] [--app-url]   # create/append
dailybot env use <name>                                  # switch active (empty = clear)
dailybot env show                                        # inspect resolved (key masked)
dailybot env list                                        # all profiles, active marked
dailybot env remove <name> [--yes]                       # delete, clears active if needed
dailybot env off                                         # kill switch (preserves active)
dailybot env on                                          # re-enable

Precedence — additive, non-breaking

env.json inserted at position 2, above agents.json default, below --profile flag:

1. --profile / --api-url / --app-url CLI flags (escape hatch)
2. .dailybot/env.json active profile (new)
3. .dailybot/profile.json::profile + agents.json
4. agents.json default
5. DAILYBOT_API_KEY env var
6. config.json::api_key
7. Login session Bearer token

Applies uniformly to get_api_key(), get_api_url(), get_app_url() in config.py, so every command (agent + user-scoped: checkin, form, kudos, chat, ask, hook, ...) picks up the override transparently.

Security posture

Three layers of protection because this file does contain plain-text API keys inside the repo tree:

1. .gitignore covers it automatically. The existing broad .dailybot/* rule (with exception only for !.dailybot/profile.json) covers env.json. Explicit comment added to .gitignore making the intent obvious and highlighting that env.json is intentionally never excepted.
2. 0o600 on every write and defensively on every load (in case an editor created the file with a lax umask).
3. Fatal refuse-if-tracked guard. On every load, git ls-files --error-unmatch .dailybot/env.json runs and raises RepoEnvError if the file is tracked. Any CLI command that would consume env.json exits non-zero with an actionable message:

   Error: /path/.dailybot/env.json is tracked by git. This file contains API keys and
   must never be committed. Fix with:
     git rm --cached .dailybot/env.json
     # ensure your .gitignore ignores .dailybot/env.json
     git commit -m 'chore: untrack .dailybot/env.json'
   The CLI refuses to load env.json while it is tracked.
   

   Plus a soft warning at write time (git check-ignore) when env.json is not currently covered by any ignore rule, so the developer catches misconfiguration early.

API keys are masked (abcd****) in every display path — same pattern as dailybot config key.

Interaction with existing files (ortogonal)

File	Committed	Contains	Rule
.dailybot/profile.json	Yes	name, default_metadata, report, vars — identity	key field fatally rejected.
.dailybot/env.json	No (gitignored)	api_key, api_url, app_url — auth context	Fatally rejected when tracked.

profile.json still governs how reports are signed even when env.json provides the credentials to send them.

Docs

• AGENTS.md — rule 14 (auth resolution order) updated to include env.json at fix(ci): unblock auto-release pipeline + cut v1.0.0 next merge #2 (annotated as a non-breaking additive layer).
• docs/CONFIGURATION.md — full new section "Repo-level env override" (schema, CLI, precedence, security, when NOT to use it).
• docs/SECURITY.md — new subsection on the three-layer protection.
• README.md — new "Env commands" section in the commands table.
• .gitignore — explicit "NEVER excepted" comment.

Tests

• tests/repo_env_test.py — 58 tests: walk-up discovery, schema validation, active resolution, disabled: true kill-switch, committed-guard (uses real git init in tmp), file permissions, precedence in get_api_key/get_api_url/get_app_url, DailyBotClient integration, resolver-provenance (for agent profiles --resolve).
• tests/env_commands_test.py — 23 tests: full CLI surface via CliRunner, including the gitignore warning + committed-guard bubbling.
• Suite: 913 → 994 passing, zero regressions.
• ruff check and mypy both clean.

Manual smoke test (before opening this PR)

Verified end-to-end in a scratch git repo:

1. env add creates the file with 0o600 and auto-active on first add ✅
2. env show masks the key ✅
3. env list marks the active profile ✅
4. env use switches ✅
5. env off / env on toggle without losing active ✅
6. Fatal guard fires when the file is force-added and committed ✅
7. Gitignore warning fires on env add in a repo without .gitignore ✅
8. Walk-up works from a nested subdirectory ✅
9. agent profiles --resolve reports env.json provenance ✅
10. get_api_key() returns env.json value even when DAILYBOT_API_KEY is set ✅

Risks

• None for backward compat — env.json is opt-in and non-existent by default; the resolver falls through untouched when the file is absent, disabled, or inert. All 913 existing tests still pass.
• One behavioral change worth noting: get_api_key() / get_api_url() / get_app_url() now do a walk-up filesystem check on every call. For the ~1-2 client constructions per invocation this is <5ms and negligible; no caching needed. If profiling ever shows this as hot, a per-process cache is trivial to add later.

Follow-up

A companion PR to DailybotHQ/agent-skill will pin the new CLI floor (once auto-release cuts this feature as a MINOR) and add a shared/env-json.md doc so agents know how to guide developers into this workflow.

Test plan

• pytest — 994 pass
• ruff check dailybot_cli tests — clean
• ruff format --check — clean
• mypy dailybot_cli — clean
• Manual smoke test (above)
• CI code_check.yml green on this PR

Made with Cursor