refactor(gate): single gate-selection authority, drop duplicate rules - #116
Merged
Conversation
WL3-800 dedup (research subagent: 4-5 duplicate gate-selection rules). - impact_planner.py: drop the hardcoded critical prefixes (00-governance/**, .github/**, scripts/ci/**) — they are already covered by risk_zones.critical in the project profile; only unknown paths keep the fail-closed critical - emit_gate_plan.py: run_* outputs are generated from the profile `gates:` keys instead of a hardcoded 5-gate tuple — adding/renaming a gate no longer requires touching CI emit code - run_quality_gate.py: GATE_PATH_SCOPES is annotated as a local convenience mapping; the canonical authority is the profile `gates:` consumed by impact_planner + emit_gate_plan (CI never reads this table) Verification: 17 passed (impact planner / profile / gate vocabulary); 111 passed + 25 subtests (tests/ci, excluding env-dependent exact_tree_review); py_compile clean; CURRENT_STATE_FRESHNESS_PASS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WL3-800 — Gate/CI dedup (research subagent identified 4-5 duplicate
gate-selection rules). PR #113 already hardened the aggregate (A1-A8); this PR
collapses the remaining duplicate selection rules to one authority.
Changes
impact_planner.py— dropped the hardcoded critical prefixes(
00-governance/**,.github/**,scripts/ci/**): they are alreadymatched by
risk_zones.criticalin the project profile. Only unknown pathskeep the fail-closed critical. (Removes duplicate rule feat(observer): add user-visible read-only dashboard #1.)
scripts/ci/emit_gate_plan.py—run_*GitHub outputs are now generatedfrom the profile
gates:keys instead of a hardcoded 5-gate tuple, soadding/renaming a gate no longer requires touching CI emit code. (Removes
duplicate rule feat(observer,r2): four-view UI + cross-project projection + WL matrix #2.)
run_quality_gate.py—GATE_PATH_SCOPESis annotated as a localconvenience mapping; the canonical selection authority is the profile
gates:consumed by impact_planner + emit_gate_plan. (CI never reads thistable — documented, not deleted, to avoid breaking the local gate UX.)
Verification
py_compileclean;CURRENT_STATE_FRESHNESS_PASS(62b331c2)