fix: bundle joserfc and reduce diracosrc noise#189
Merged
chrisburr merged 4 commits intoJun 23, 2026
Conversation
diracx-core depends on joserfc for JOSE/JWT handling but it was not part of the DIRACOS bundle, so a fresh installation had to pull it (and its dependencies) from PyPI on first use. Closes DIRACGrid#173
Sourcing diracosrc set PYTHONWARNINGS=ignore, which globally suppressed all Python warnings (deprecations, etc.) for everything run in the environment. Remove it so warnings surface as expected. Closes DIRACGrid#146
When diracosrc is sourced under 'set -x', checkDir expanded the full directory listing into the trace, so a CA certificate directory dumped every filename. xtrace was previously only disabled around the 'ls' itself; the subsequent emptiness test still expanded the captured list. Keep xtrace off through the whole check and only restore it before returning, so the listing never reaches the trace.
The <0.19 upper bound is no longer needed; allow any version to be selected by the solver.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
joserfc(required bydiracx-core) so a fresh DIRACOS install no longer pulls it, and its dependencies, from PyPI on first use.diracosrcexportedPYTHONWARNINGS=ignore, which globally suppressed all Python warnings for everything run in the environment.diracosrcunderset -x:checkDirexpanded the full directory listing into the trace, so sourcing under xtrace dumped every certificate filename from a CA cert directory. xtrace now stays off through the emptiness test and is only restored before returning.ruamel.yamlbuild dependency.Closes #173
Closes #146
BEGINRELEASENOTES
FIX: bundle joserfc which is required by diracx-core (#173)
FIX: stop silencing all Python warnings when sourcing diracosrc (#146)
FIX: do not print every certificate when sourcing diracosrc under
set -xCHANGE: drop the version constraint on the ruamel.yaml build dependency
ENDRELEASENOTES